fix: preserve signed electrum unconfirmed balance - #17
Open
noahjoeris wants to merge 2 commits into
Open
Conversation
Electrum returns unconfirmed as a signed mempool delta; simply flipping the amount to positive can look like BTC received instead of BTC spent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
blockchain.scripthash.get_balancereturnsunconfirmedas a signed amount. When confirmed coins are spent in the mempool it can be negative. At the moment we simply turn it into a positive amount. Meaning if we receive 1 BTC or if we spend 1 BTC both is shown the same way.Example: we spend 100 confirmed sats, this results in -100 unconfirmed sats. If we turn it positive a user can think he has now 200 sats (100 sats incoming).
Solution
unconfirmedasSignedAmountand deserialize withbitcoin::amount::serde::as_sat(preserve the sign).as_sat/as_btchelpers and drop the local equivalents.