Disallow empty blocks response - #113
Merged
Merged
Conversation
ValuedMammal
reviewed
Dec 3, 2024
oleonardolima
left a comment
oleonardolima
left a comment
Collaborator
There was a problem hiding this comment.
Concept ACK
I guess you'd need to fix formatting, per CI step. Agree with VM's suggestion.
rustaceanrob
force-pushed
the
err-12-3
branch
from
December 3, 2024 20:17
9858cfa to
340cd1c
Compare
Member
Author
|
Ok updated and should pass CI |
Pull Request Test Coverage Report for Build 12147421367Details
💛 - Coveralls |
8 tasks
ValuedMammal
approved these changes
Dec 4, 2024
ValuedMammal
left a comment
ValuedMammal
left a comment
Contributor
There was a problem hiding this comment.
ACK 340cd1c
@notmandatory Do you want to include this in #112?
8 tasks
chrono-raven6i90
added a commit
to chrono-raven6i90/rust-esplora-client
that referenced
this pull request
Oct 28, 2025
…sponse 340cd1cb97c6d9e3b08306b69eb50bc16a4cab19 fix(client): disallow empty blocks response (Rob N) Pull request description: This is my first attempt at resolving the empty blocks response at the client level. I didn't find that any of the current error variants accurately described the problem, but could use some outside opinions @oleonardolima @notmandatory ACKs for top commit: ValuedMammal: ACK 340cd1cb97c6d9e3b08306b69eb50bc16a4cab19 oleonardolima: utACK 340cd1cb97c6d9e3b08306b69eb50bc16a4cab19 Tree-SHA512: fc79b40fc499727d0061142d6906ae3b1f1672c507181c0c86d9527afdcdaea82e8b0e8af64a7e2463e3f4ed84595d666e854fe97d070a900cfe5a10d25b4af8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first attempt at resolving the empty blocks response at the client level. I didn't find that any of the current error variants accurately described the problem, but could use some outside opinions
@oleonardolima @notmandatory