fix(ci): pin tokio to 1.38.1 on MSRV step - #94
Merged
notmandatory merged 1 commit intoAug 22, 2024
Merged
Conversation
oleonardolima
changed the title
oleonardolima
marked this pull request as ready for review
August 22, 2024 14:21
notmandatory
approved these changes
Aug 22, 2024
chrono-raven6i90
added a commit
to chrono-raven6i90/rust-esplora-client
that referenced
this pull request
Oct 28, 2025
…8.1 on MSRV step 16cdd384b23fdfe76c5b2934d824bdb04891d240 fix(ci): pin tokio to 1.38.1 on msrv step (Leonardo Lima) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description As previously noticed on bitcoindevkit/bdk#1524, tokio raised their MSRV to `1.70.0` in their latest release, in short it was because they moved to `mio 1.0` which requires `1.70.0` MSRV. Although we don't have `tokio` as a direct dependency on `rust-esplora-client` it comes as a transitive dependency from `reqwest`. This PR adds the necessary pinning on CI and updates the instruction on `README.md` in order to properly build on MSRV. <!-- Describe the purpose of this PR, what's being adding and/or fixed --> ### Notes to the reviewers <!-- In this section you can include notes directed to the reviewers, like explaining why some parts of the PR were done in a specific way --> ### Changelog notice - Adds another MSRV pinning step on CI for the `tokio 1.38.1`. <!-- Notice the release manager should include in the release tag message changelog --> <!-- See https://keepachangelog.com/en/1.0.0/ for examples --> ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing <!-- #### New Features: * [ ] I've added tests for the new feature * [ ] I've added docs for the new feature #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [ ] I'm linking the issue being fixed by this PR --> ACKs for top commit: notmandatory: ACK 16cdd384b23fdfe76c5b2934d824bdb04891d240 Tree-SHA512: 3b98bc96ff797b67bcec215bc957561698e06c74d4184780aff4d129630f2216f2aa415a0042f3551a9d6197d6aa376cb540daf2a5ead996f4ba20b1674e4215
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As previously noticed on bitcoindevkit/bdk#1524, tokio raised their MSRV to
1.70.0in their latest release, in short it was because they moved tomio 1.0which requires1.70.0MSRV.Although we don't have
tokioas a direct dependency onrust-esplora-clientit comes as a transitive dependency fromreqwest.This PR adds the necessary pinning on CI and updates the instruction on
README.mdin order to properly build on MSRV.Notes to the reviewers
Changelog notice
tokio 1.38.1.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing