Make generate_and_send_coins send rewards to bech32 address.#131
Make generate_and_send_coins send rewards to bech32 address.#131jnewbery merged 1 commit intobitcoinops:masterfrom
Conversation
|
I'm confused about the rationale here. Presumably we'd been making weight comparisons between transactions we create ourselves (see #129 for example) |
|
Sorry, the rational isn't correct. In the chapter 2.2 update (#133) , I compare two transactions.
For the weight comparison, I prefer (it isn't necessary) to minimize the weight of both transactions, by spending native segwit coinbase outputs in both cases. |
|
for (ii), how are you adding the commitment to the transaction output if you're creating the tx with |
With a tweaked pubkey which is encoded in the segwit v1 address passed to |
|
Hi @jnewbery - anything I can do to move this forward if desirable? |
|
Sorry for the delay here. Using bech32 everywhere seems reasonable to me. Thanks! |
Default
generate()call sends rewards to P2SH(P2WPKH) output.Sending rewards to a native segwit address reduces weight of spending transaction and facilitates weight comparisons between native segwit v0 and v1 transactions.I would prefer minimizing transaction weights where possible.