Add callback for handling link errors in disconnected state#482
Merged
Add callback for handling link errors in disconnected state#482
Conversation
Previously, there was no way to hook into link errors when the state was disconnected. On the initial connection attempt, a callback would be triggered for a failed connection, allowing scripts to handle the error. However, subsequent attempts in the disconnected state did not trigger any callback, forcing autonomous scripts to blindly retry with a timeout. This commit introduces a `disconnected_link_error` callback, enabling scripts to respond to link errors more effectively and retry connections programmatically.
tobbeanton
approved these changes
Oct 4, 2024
Member
tobbeanton
left a comment
tobbeanton
left a comment
There was a problem hiding this comment.
That is a really good addition. It all looks good for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there was no way to hook into link errors when the state was disconnected.
For example, when somehow unable to connect to a CF (let's say because it was turned off); on the initial connection attempt, a callback would be triggered for a failed connection, allowing scripts to handle the error. However, subsequent attempts did not trigger any callback, forcing autonomous scripts to blindly retry with a timeout. This commit introduces a
disconnected_link_errorcallback, enabling scripts to respond to link errors more effectively and retry connections programmatically.