LocalCalendar/LocalEvent: provide all fields for DAVx5#15
Merged
Conversation
rfc2822
force-pushed
the
androidcalendar-features
branch
from
16e0d65 to
87f9b76
Compare
rfc2822
changed the title
rfc2822
force-pushed
the
androidcalendar-features
branch
from
95455ce to
a4fd57f
Compare
rfc2822
force-pushed
the
androidcalendar-features
branch
from
2878edf to
6530bba
Compare
4 tasks
rfc2822
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DAVx5 LocalCalendar/LocalEvent functionality by moving field handling (such as organizer status, sync metadata, and event sequencing) into the library, eliminating the need for client-side overrides of populate/build functions.
- Added a new isOrganizer field in Event
- Refactored AndroidEvent constructors and methods to support library-managed fields
- Updated AndroidCalendar and test cases to align with these changes
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/main/kotlin/at/bitfire/ical4android/Event.kt | Added isOrganizer field to the Event data class |
| lib/src/main/kotlin/at/bitfire/ical4android/AndroidEvent.kt | Made AndroidEvent an open class, introduced sync metadata fields, and refactored populate/build methods |
| lib/src/main/kotlin/at/bitfire/ical4android/AndroidCalendar.kt | Updated calendar handling and integrated new sync state methods |
| lib/src/androidTest/kotlin/at/bitfire/ical4android/impl/TestEvent.kt | Updated TestEvent constructor to match the new AndroidEvent structure |
| lib/src/androidTest/kotlin/at/bitfire/ical4android/AndroidEventTest.kt | Added tests for the new sync metadata and isOrganizer handling |
| lib/src/androidTest/kotlin/at/bitfire/ical4android/AndroidCalendarTest.kt | Adjusted color insertion tests to use the updated Css3Color.entries |
sunkup
approved these changes
Jun 25, 2025
Member
sunkup
left a comment
sunkup
left a comment
There was a problem hiding this comment.
I find it hard to spot errors here. Maybe we should move all the companion objects to the end of their class. I think it looks good otherwise.
Member
Author
Yes, me too … I think it's because the architecture is far too bad yet. But it has to start somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves functionality from DAVx5
LocalCalendarandLocalEventto the library so that there's no need to overridepopulate…andbuild…anymore.To be combined with bitfireAT/davx5-ose#1544