New actions, renamed existing ones and descriptions for all#12
Merged
bryce-seifert merged 5 commits intobitfocus:mainfrom Jul 24, 2023
Merged
New actions, renamed existing ones and descriptions for all#12bryce-seifert merged 5 commits intobitfocus:mainfrom
bryce-seifert merged 5 commits intobitfocus:mainfrom
Conversation
…ies and wording in general plus descriptions
Member
|
@qqquiu Just tested these actions, and all looks good. Would you be able to run |
Contributor
Author
It should be good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on reviewing, adding and updating API-available actions. It requires using version 23 or above of VDO.Ninja.
Testing
nextSlideandpreviousSlideReordered actions
Inside
action.jsthey're ordered based on:Inside
HELP.mdthey're listed on the same categories, but ordered more relevantly to the user or similarity-based.Action IDs and "parameters"
The IDs remain unchanged as to avoid problems with current users of the module, however actions that manipulate groups should now accept an integer 1-8 only (previously accepted strings, too).
While the API seems to accept strings (similar to how scenes work) - I was not able to test this functionality with strings, I decided to force integers as per the API documentation, at least for now.
Action descriptions
All actions should now have a description mostly based on how the API describes the function, with minor changes to keep things simple and easy to read.
Renamed actions
General
Control Rooms
New actions
Local
forceKeyframenextSlidepreviousSlideDirector
Targets self (starts after
forceKeyframe)groupjoinGroupleaveGroupviewGroupjoinViewGroupleaveViewGroupsoloVideoTargets room guest
soloChatsoloChatBidirectionalFuture plans
I intend to implement feedbacks (higher priority) and presets (lower priority) based on the new functionality.