Skip to content
This repository was archived by the owner on Jan 24, 2019. It is now read-only.

Remove check for >0 upstreams#426

Merged
jehiah merged 1 commit into
bitly:masterfrom
bluecmd:patch-4
Aug 29, 2017
Merged

Remove check for >0 upstreams#426
jehiah merged 1 commit into
bitly:masterfrom
bluecmd:patch-4

Conversation

@bluecmd

@bluecmd bluecmd commented Jul 20, 2017

Copy link
Copy Markdown
Contributor

When used solely for auth_request there is no upstream.
Instead of forcing users to set a dummy upstream, remove
the check.

@ploxiln

ploxiln commented Jul 20, 2017

Copy link
Copy Markdown
Contributor

Makes sense to me - could log a warning though.

Looks like you need to update TestNewOptions.

When used solely for auth_request there is no upstream.
Instead of forcing users to set a dummy upstream, remove
the check.
@bluecmd

bluecmd commented Jul 20, 2017

Copy link
Copy Markdown
Contributor Author

@ploxiln Right you are. Amended the previous commit, please have a look!

@ploxiln

ploxiln commented Jul 20, 2017

Copy link
Copy Markdown
Contributor

👍

@jehiah jehiah merged commit 11bdcc9 into bitly:master Aug 29, 2017
@jehiah jehiah added this to the v2.3 milestone Oct 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants