Commit 255d92b
authored
**Description of the change**
This PR adds the explicit `protocol: TCP` field to the port definitions
in the Sealed Secrets Helm chart.
While TCP is the default protocol in Kubernetes, Server-Side Apply (SSA)
on clusters running version 1.19 or earlier can reject manifests if the
protocol is not explicitly defined. This change ensures the Helm chart
is compatible with modern GitOps workflows (like ArgoCD or Flux using
SSA) across all supported Kubernetes versions.
**Targeted Files:**
- `templates/deployment.yaml`: Added `protocol: TCP` to the http and
metrics container ports.
- `templates/service.yaml`: Added `protocol: TCP` to the main service
and metrics service port definitions.
**Benefits**
- Resolves deployment failures when using Server-Side Apply on older
Kubernetes clusters (<= 1.19).
- Improves manifest explicitness and follows best practices for
cross-version compatibility.
**Applicable issues**
- fixes #692
**Checklist**
- [x] I have read the CONTRIBUTING doc.
- [x] My commit is Signed-off-by using `git commit -s`.
- [ ] (If applicable) Table of Contents in `README.md` or `values.txt`
has been updated via `doctoc`.
- [x] Changes are focused solely on the Helm YAML templates as
requested.
Signed-off-by: Emmanuel Tom Jose <84658038+leantos@users.noreply.github.com>
1 parent de6d9d7 commit 255d92b
2 files changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| 184 | + | |
184 | 185 | | |
185 | 186 | | |
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
189 | 190 | | |
190 | 191 | | |
| 192 | + | |
191 | 193 | | |
192 | 194 | | |
193 | 195 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| 71 | + | |
70 | 72 | | |
71 | 73 | | |
72 | 74 | | |
| |||
0 commit comments