fix: explicitly specify TCP protocol for helm SSA compatibility (#692)#1901
Merged
alvneiayu merged 1 commit intobitnami-labs:mainfrom Mar 12, 2026
Merged
Conversation
…ami-labs#692) Signed-off-by: Emmanuel Tom Jose <84658038+leantos@users.noreply.github.com>
alvneiayu
approved these changes
Mar 12, 2026
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 13, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [bitnami-labs/sealed-secrets](https://github.com/bitnami-labs/sealed-secrets) | patch | `v0.36.0` → `v0.36.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>bitnami-labs/sealed-secrets (bitnami-labs/sealed-secrets)</summary> ### [`v0.36.1`](https://github.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0361) [Compare Source](bitnami-labs/sealed-secrets@v0.36.0...v0.36.1) - Doc/issue 501 all namespaces ([#​1900](bitnami-labs/sealed-secrets#1900)) - Bump go 1.26.1 ([#​1914](bitnami-labs/sealed-secrets#1914)) - Update actions/setup-go to v6.2.0 ([#​1906](bitnami-labs/sealed-secrets#1906)) - fix: explicitly specify TCP protocol for helm SSA compatibility ([#​692](bitnami-labs/sealed-secrets#692)) ([#​1901](bitnami-labs/sealed-secrets#1901)) - docs: document GKE Warden and RBAC restrictions ([#​1892](bitnami-labs/sealed-secrets#1892)) - Bump k8s.io/klog/v2 from 2.130.1 to 2.140.0 ([#​1913](bitnami-labs/sealed-secrets#1913)) - chore: remove note about deprecation of helm chart. ([#​1902](bitnami-labs/sealed-secrets#1902)) - Bump k8s.io/code-generator from 0.35.1 to 0.35.2 ([#​1909](bitnami-labs/sealed-secrets#1909)) - Bump k8s.io/client-go from 0.35.1 to 0.35.2 ([#​1908](bitnami-labs/sealed-secrets#1908)) - Bump distroless/static from `d90359c` to `28efbe9` in /docker ([#​1912](bitnami-labs/sealed-secrets#1912)) - Fix oci push action ([#​1899](bitnami-labs/sealed-secrets#1899)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My42NC4zIiwidXBkYXRlZEluVmVyIjoiNDMuNjQuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds the explicit
protocol: TCPfield to the port definitions in the Sealed Secrets Helm chart.While TCP is the default protocol in Kubernetes, Server-Side Apply (SSA) on clusters running version 1.19 or earlier can reject manifests if the protocol is not explicitly defined. This change ensures the Helm chart is compatible with modern GitOps workflows (like ArgoCD or Flux using SSA) across all supported Kubernetes versions.
Targeted Files:
templates/deployment.yaml: Addedprotocol: TCPto the http and metrics container ports.templates/service.yaml: Addedprotocol: TCPto the main service and metrics service port definitions.Benefits
Applicable issues
Checklist
git commit -s.README.mdorvalues.txthas been updated viadoctoc.