Skip to content
This repository was archived by the owner on Apr 3, 2019. It is now read-only.

Allow multiple instances of bitcore-lib with the same version - #4

Closed
pnagurny wants to merge 1 commit into
bitpay:masterfrom
pnagurny:feature/multiple-instances
Closed

Allow multiple instances of bitcore-lib with the same version#4
pnagurny wants to merge 1 commit into
bitpay:masterfrom
pnagurny:feature/multiple-instances

Conversation

@pnagurny

Copy link
Copy Markdown
Contributor

No description provided.

@pnagurny
pnagurny force-pushed the feature/multiple-instances branch from df94001 to 09fca53 Compare October 20, 2015 18:49
@braydonf

Copy link
Copy Markdown
Contributor

I think we still want to have a warning in the case that the original was used, as there could be changes outside the version number, especially during debugging.

@fanatid

fanatid commented Oct 27, 2015

Copy link
Copy Markdown
Contributor

If you allow multiple instances of one version you return original problem that was related with $.checkArgumentType:

// in some library X
exports = function () {
  return require('bitcore-lib').Transaction.Input(...)
}

// in code that use library X
require('bitcore-lib').Transaction().addInput(require('x')()) // throw InvalidArgumentType

@matiu

matiu commented Oct 26, 2017

Copy link
Copy Markdown
Contributor

Closing, too old / stalled. Please reopen if active.

@matiu matiu closed this Oct 26, 2017
nitsujlangston pushed a commit to nitsujlangston/bitcore-lib that referenced this pull request Feb 25, 2019
# This is the 1st commit message:

Tag future transactions if config is set

# This is the commit message bitpay#2:

Adding bitcore-client package.json

# This is the commit message bitpay#3:

Testing version number

# This is the commit message bitpay#4:

Updating test dockerfile and lerna json
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants