[BCN] fix gnosis token history casing gap and return 400 for invalid ethmultisig addresses#4199
Open
msalcala11 wants to merge 1 commit into
Open
[BCN] fix gnosis token history casing gap and return 400 for invalid ethmultisig addresses#4199msalcala11 wants to merge 1 commit into
msalcala11 wants to merge 1 commit into
Conversation
8fdf01c to
331cb7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two fixes for Gnosis multisig token history:
effects.*addresses case-sensitively against checksummed values, but effect addresses weren't checksummed at ingestion until 1df6336, andeffects.*was never backfilled (fixEvmTxToFromAddressesCase.jsonly rewrites top-levelto/from). Docs synced before then store lowercase effect addresses, so the query silently drops them before the case-insensitive matching from #4186 can see them. The query now accepts both casings.toChecksumAddressthrow and the endpoint returns a 500 (previously an empty 200). It now returns a 400.Changelog
effects.contractAddress,effects.from, andeffects.toin the Gnosis transaction query via$in(still uses the existing indexes)./ethmultisig/transactions/:multisigContractAddress, validating with the same validation logic astoChecksumAddress.Testing Notes
cd packages/bitcore-node && npm run test:unit— the "EVM token wallet history filtering" suite covers both the query shape and row emission. On Node below 22.12, run withNODE_OPTIONS=--experimental-require-module.GET /api/ETH/mainnet/ethmultisig/transactions/notanaddressreturns 400 (previously 500); valid addresses in either casing stream normally.Checklist