Skip to content

[REF] rename from pax to usdp#369

Merged
JohnathanWhite merged 3 commits into
bitpay:masterfrom
gabrielbazan7:ref/paxosDollar
Sep 20, 2022
Merged

[REF] rename from pax to usdp#369
JohnathanWhite merged 3 commits into
bitpay:masterfrom
gabrielbazan7:ref/paxosDollar

Conversation

@gabrielbazan7

@gabrielbazan7 gabrielbazan7 commented Aug 31, 2022

Copy link
Copy Markdown
Collaborator

Fixes:

  • paying invoices is not possible right now

  • show correct name and symbol when creating a wallet

iPhone_12

  • Rate not found for currency: usdp

  • possible duplicated key error if wrong pax wallet is created

@gabrielbazan7
gabrielbazan7 force-pushed the ref/paxosDollar branch 2 times, most recently from 080b6fb to b3c5af9 Compare August 31, 2022 18:17
@JohnathanWhite

Copy link
Copy Markdown
Collaborator

need to rebase

@gabrielbazan7
gabrielbazan7 force-pushed the ref/paxosDollar branch 5 times, most recently from b5cb5ca to fd3cfdb Compare September 7, 2022 15:03
cmgustavo
cmgustavo previously approved these changes Sep 15, 2022

@cmgustavo cmgustavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! 💪🏼

@gabrielbazan7 gabrielbazan7 changed the title [REF] rename from pax to usdp WIP [REF] rename from pax to usdp Sep 15, 2022
@cmgustavo
cmgustavo self-requested a review September 15, 2022 14:28
@cmgustavo
cmgustavo dismissed their stale review September 15, 2022 14:29

Pay invoice

@gabrielbazan7 gabrielbazan7 changed the title WIP [REF] rename from pax to usdp [REF] rename from pax to usdp Sep 16, 2022

@rastajpa rastajpa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@cmgustavo cmgustavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnathanWhite
JohnathanWhite merged commit 17ce070 into bitpay:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants