fix: init audit after bootstrap in the --bootstrap run#252
fix: init audit after bootstrap in the --bootstrap run#252bastienboutonnet merged 5 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 82.48% 82.48%
=======================================
Files 20 20
Lines 1205 1205
=======================================
Hits 994 994
Misses 211 211
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.01%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Description
When running
audit --bootstrapwhile the bootstrap was running successfully, we were initialising theaudittask before thebootstraptask. Since theaudittask builds its knowledge of dbt models and their descriptions at__init__()time, the bootstrapped model descriptors were not yet available.This PR moves the initialisation of
audittask to after the bootstrap task has run.How was the change tested
Tested interactively
Issue Information
(If your PR addresses or closes a GitHub issue please write "Closes #<issue_number>" or something like that).
Checklist
(Ideally, all boxes are checked by the time we merged the PR, if you don't know how to do any of these don't hesitate to say so in the PR and we'll help you out.)