Compress images u2fkey/yubikey using avif/webp - #1232
Conversation
|
Hi @simon04, Thanks for the PR. I noticed there's a fair bit of quality loss especially for the avif images. I think it's worth aiming for a lossless or higher quality of compression for the images even if they end up being slightly larger. We also have a few other images which could benefit from compression. I also noticed the original images were removed but still keept in the |
|
Sorry for the long silence. Today, I've restored the original JPEG files and improved the quality of the AVIF files. |
# Conflicts: # src/app/accounts/two-factor.component.html # src/connectors/webauthn.html # webpack.config.js
|
@simon04 I've rebased this with the prettier changes. added alternatives for u2fkey-mobile and tweaked the avif and webp quality slightly. I believe this is ready to be merged now. Since I've pushed commits to this PR I will get a second reviewer to verify everything looks good. I also took the time and compressed the original jpegs in #1374. Thanks for the contribution! |
Use modern image formats avif/webp.
Reference: https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture
Tool used: https://squoosh.app/