Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Update client for authService refactor - #1387

Merged
Hinton merged 14 commits into
masterfrom
refactor/authService
Feb 7, 2022
Merged

Update client for authService refactor#1387
Hinton merged 14 commits into
masterfrom
refactor/authService

Conversation

@eliykat

@eliykat eliykat commented Jan 12, 2022

Copy link
Copy Markdown
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Client update for bitwarden/jslib#588.

Code changes

Minor updates to use new services and to update dependencies.

jslib must be merged first.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@eliykat
eliykat marked this pull request as draft January 12, 2022 04:14
@eliykat
eliykat marked this pull request as ready for review January 17, 2022 03:20
@eliykat
eliykat marked this pull request as draft February 1, 2022 03:28
@eliykat eliykat changed the title [Tech debt] Refactor authService Update client for authService refactor Feb 1, 2022
@MGibson1

MGibson1 commented Feb 3, 2022

Copy link
Copy Markdown
Member

@eliykat since jslib PR is merged, is this ready to go?

Do we need to get these client updates in for Feb release?

@eliykat
eliykat marked this pull request as ready for review February 7, 2022 01:31
@eliykat

eliykat commented Feb 7, 2022

Copy link
Copy Markdown
Member Author

@MGibson1 ready to go now. This is all for the March release.

@eliykat
eliykat requested a review from a team February 7, 2022 01:45
Hinton
Hinton previously approved these changes Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants