This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Fix AT32F405 flash size/map#2032
Merged
Merged
Conversation
dragonmux
approved these changes
Dec 22, 2024
Member
dragonmux
left a comment
There was a problem hiding this comment.
LGTM, merging. Thank you for the contribution and this fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
For a (C) 256 KiB flash part, the F_SIZE "register" contains not 262144 but 256, which (as used in PR1949 26d27b9) generates a target flash map of 256 byte length and 2048 (or 1024) byte erase-sectors, which is broken.
Assumed tested on some BMD-derivative platform.
Your checklist for this pull request
Closing issues