This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Feature: blackpill-f4 better control of pin mode#2044
Merged
dragonmux merged 3 commits intoJan 8, 2025
Conversation
dragonmux
previously approved these changes
Jan 7, 2025
Member
dragonmux
left a comment
There was a problem hiding this comment.
This LGTM and brings the platform up to parity with a couple of the others 👍🏼, merging. Thank you for the contribution!
* Pulling up TRST is required to scan Raspberry Pi 3B (BCM2837) and other JTAG targets * jtagtap.c will gpio_clear() it if available
* Prevent drive fight with G030J6 * Allow multiple debuggers on same target without detaching this one * Directional buffers will need an extra pin
69437f3 to
ab6d92e
Compare
dragonmux
approved these changes
Jan 8, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
platform_target_clk_output_enable()which switches SWCLK/SWDIO to inputs or outputs.This should allow keeping multiple BMPs wired up to a single target for cross-testing etc. and should prevent drive fight with low pin count chips like STM32G030J6 (I don't have one) or which remap their PA13/14 to output mode otherwise. No known shields/carriers/mainboards exist for it which have directional buffers and TCK_OEn aka TCK_DIR_PIN -- it would need similar treatment.
TRST pin high is required to even scan Raspberry Pi 3B (BCM2837), otherwise its TAP is disabled (default weak pull-down).
Pending testing on
blackpill-f411ce.Your checklist for this pull request
Closing issues
Fixes #1868 point 3 for this board.