docs/Index-Mapping: Make reference to the actual interface path#11
Open
xescugc wants to merge 1 commit intoblevesearch:masterfrom
Open
docs/Index-Mapping: Make reference to the actual interface path#11xescugc wants to merge 1 commit intoblevesearch:masterfrom
xescugc wants to merge 1 commit intoblevesearch:masterfrom
Conversation
While reading the docs it was hard to find the 'Classifier' as I was searching it inside the root directory as you have here documented. It's not actually there so this updates the path to the actual one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the docs it was hard to find the 'Classifier' as I was searching it inside
the root directory as you have here documented. It's not actually there so this
updates the path to the actual one.
I was also thinking on adding the link to the code (https://github.com/blevesearch/bleve/blob/ae28975038cb25655da968e3f043210749ba382b/mapping/mapping.go#L28) for easy finding, or even adding a bit more on the docs when it mentions the
Type()to be likeType() string, but nevertheless if it has to implement an interface it may (does not) have more methods to fulfill.Also IDK if you accept PRs or this is generated from another place hehe.