-
Notifications
You must be signed in to change notification settings - Fork 22
feat(staged): cache the project list in a shared store so project views paint instantly #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b7f94de
feat(staged): add shared projectsData store for project list, branche…
matt2e 3105bc0
feat(staged): consume shared projectsData store across project views
matt2e c058539
feat(staged): hoist projects sidebar to App shell and share it with t…
matt2e 39793da
feat(staged): gate store readiness on the project list, not full hydr…
matt2e 17a4479
fix(staged): hydrate on demand before the project-delete safety check
matt2e 7a493a3
fix(staged): bump the load generation on project delete so stale appl…
matt2e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
apps/staged/src/lib/features/projects/ProjectDeleteDialog.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <!-- | ||
| ProjectDeleteDialog.svelte - Shared remove-project confirmation dialog | ||
|
|
||
| Mounted once in App.svelte and driven by projectActions.pendingDelete, so | ||
| every remove-project entry point (sidebar context menu on the project and | ||
| repos routes, landing-grid context menu, ProjectHome's top-bar button and | ||
| shortcut) shares one confirmation flow. | ||
| --> | ||
| <script lang="ts"> | ||
| import * as AlertDialog from '$lib/components/ui/alert-dialog'; | ||
| import { projectDisplayName } from '../../shared/utils'; | ||
| import { projectActions } from './projectActions.svelte'; | ||
| </script> | ||
|
|
||
| <AlertDialog.Root | ||
| open={projectActions.pendingDelete !== null} | ||
| onOpenChange={(v) => !v && projectActions.cancelPendingDelete()} | ||
| > | ||
| <AlertDialog.Content> | ||
| {#if projectActions.pendingDelete} | ||
| <AlertDialog.Header> | ||
| <AlertDialog.Title>Remove Project</AlertDialog.Title> | ||
| <AlertDialog.Description> | ||
| {`Remove "${projectDisplayName(projectActions.pendingDelete)}" from Staged? There are unmerged changes in this project's branches. Deleting this project will lose any changes not pushed to GitHub.`} | ||
| </AlertDialog.Description> | ||
| </AlertDialog.Header> | ||
| <AlertDialog.Footer> | ||
| <AlertDialog.Cancel>Cancel</AlertDialog.Cancel> | ||
| <AlertDialog.Action | ||
| variant="destructive" | ||
| onclick={() => projectActions.confirmPendingDelete()} | ||
| > | ||
| Remove | ||
| </AlertDialog.Action> | ||
| </AlertDialog.Footer> | ||
| {/if} | ||
| </AlertDialog.Content> | ||
| </AlertDialog.Root> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When users switch from a project to Repos, this keeps
ProjectsSidebarmounted whileProjectHomeunmounts; I checked the repo and onlyProjectHome/ProjectsListcallprojectRunActionsStore.startListening, andProjectHomecleanup callsstopListening, which clears executions. Any running run-action badge/activity in the surviving sidebar therefore disappears or stops updating on the Repos route; start/hydrate the run-action store from the sidebar or App as well.Useful? React with 👍 / 👎.