-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add animated profile avatars #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
63b576b
Add animated profile avatars
klopez4212 4e0f84e
Fix animated avatar CI assertions
klopez4212 1b27ca4
Stabilize animated avatar smoke test
klopez4212 3ba1229
Polish animated avatar onboarding
klopez4212 ce8d91f
Update animated avatar smoke expectation
klopez4212 47c067e
Merge remote-tracking branch 'origin/main' into kennylopez-animated-a…
klopez4212 c0a86eb
Preserve blank camera labels
klopez4212 283d51a
Stabilize animated avatar camera smoke test
klopez4212 3543e3d
Keep avatar editor disabled while saving
klopez4212 736fdbf
Fix animated avatar camera smoke locator
klopez4212 35f9c9a
Strip animated avatar fragments for cache fetches
klopez4212 57319aa
Guard animated avatar apply state
klopez4212 e8c0dce
Satisfy animated avatar file size check
klopez4212 3b81bf3
Disable onboarding nav during avatar uploads
klopez4212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
desktop/src/features/profile/lib/animatedAvatarCapture.test.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import assert from "node:assert/strict"; | ||
| import test from "node:test"; | ||
|
|
||
| import { listAvatarCameras } from "./animatedAvatarCapture.ts"; | ||
|
|
||
| function mockMediaDevices(devices) { | ||
| Object.defineProperty(globalThis, "navigator", { | ||
| configurable: true, | ||
| value: { | ||
| mediaDevices: { | ||
| enumerateDevices: async () => devices, | ||
| }, | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| test("listAvatarCameras: preserves blank pre-permission camera labels", async () => { | ||
| mockMediaDevices([ | ||
| { | ||
| deviceId: "default", | ||
| kind: "videoinput", | ||
| label: "", | ||
| }, | ||
| { | ||
| deviceId: "continuity", | ||
| kind: "videoinput", | ||
| label: "", | ||
| }, | ||
| { | ||
| deviceId: "microphone", | ||
| kind: "audioinput", | ||
| label: "Studio Mic", | ||
| }, | ||
| ]); | ||
|
|
||
| const cameras = await listAvatarCameras(); | ||
|
|
||
| assert.deepEqual(cameras, [ | ||
| { deviceId: "default", label: "" }, | ||
| { deviceId: "continuity", label: "" }, | ||
| ]); | ||
| assert.equal( | ||
| cameras.some((device) => device.label.trim().length > 0), | ||
| false, | ||
| ); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.