Skip to content

Add goose and Ollama as first-class onboarding providers #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
james-see wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add goose and Ollama as first-class onboarding providers #2464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions desktop/src/features/agents/ui/agentConfigOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const KNOWN_LLM_PROVIDER_IDS = [
"anthropic",
"databricks",
"databricks_v2",
"ollama",
"openai",
"openai-compat",
] as const;
Expand Down Expand Up @@ -109,6 +110,11 @@ const PROVIDER_CREDENTIAL_CONFIG: Partial<
"databricks-v2": {
requiredEnvKeys: ["DATABRICKS_HOST"],
},
ollama: {
// Ollama runs locally — no API key or host required (defaults to
// http://localhost:11434). Set OLLAMA_BASE_URL only for non-default hosts.
requiredEnvKeys: [],
},
};

const DEFAULT_MODEL_OPTION: PersonaModelOption = {
Expand All @@ -120,6 +126,7 @@ export const PERSONA_LLM_PROVIDER_OPTIONS: readonly PersonaModelOption[] = [
{ id: "anthropic", label: "Anthropic" },
{ id: "openai", label: "OpenAI" },
{ id: "openai-compat", label: "OpenAI-compatible" },
{ id: "ollama", label: "Ollama (local)" },
{ id: "relay-mesh", label: "Buzz shared compute" },
{ id: "databricks", label: "Databricks" },
{ id: "databricks_v2", label: "Databricks v2" },
Expand Down
6 changes: 3 additions & 3 deletions desktop/src/features/onboarding/ui/onboardingRuntimeSelection.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function runtime(id, availability, status) {
test("only Claude Code and Codex are visible in onboarding", () => {
assert.equal(runtimeIsVisibleInOnboarding("claude"), true);
assert.equal(runtimeIsVisibleInOnboarding("codex"), true);
assert.equal(runtimeIsVisibleInOnboarding("goose"), false);
assert.equal(runtimeIsVisibleInOnboarding("goose"), true);
assert.equal(runtimeIsVisibleInOnboarding("buzz-agent"), false);
assert.equal(runtimeIsVisibleInOnboarding("custom"), false);
});
Expand All @@ -30,7 +30,7 @@ test("visible onboarding runtimes use the product order", () => {

assert.deepEqual(
getVisibleOnboardingRuntimes(runtimes).map(({ id }) => id),
["claude", "codex"],
["goose", "claude", "codex"],
);
});

Expand Down Expand Up @@ -65,6 +65,6 @@ test("ready onboarding runtimes exclude hidden ready harnesses", () => {

assert.deepEqual(
getReadyOnboardingRuntimes(runtimes).map(({ id }) => id),
["claude"],
["goose", "claude"],
);
});
2 changes: 1 addition & 1 deletion desktop/src/features/onboarding/ui/onboardingRuntimeSelection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { AcpRuntimeCatalogEntry } from "@/shared/api/types";

export const ONBOARDING_RUNTIME_ORDER = ["claude", "codex"];
export const ONBOARDING_RUNTIME_ORDER = ["goose", "claude", "codex"];

const VISIBLE_ONBOARDING_RUNTIME_IDS = new Set<string>(
ONBOARDING_RUNTIME_ORDER,
Expand Down