Skip to content

fix(desktop): Windows sidecar stubs, managed Node, onboarding scroll #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(desktop): Windows sidecar stubs, managed Node, onboarding scroll #2496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f7ee9
fix(desktop): add .exe suffix to Windows sidecar stubs
Chessing234 Jul 23, 2026
da4d01c
fix(desktop): let machine onboarding steps scroll under the docked CTA
Chessing234 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions Justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,12 @@ _ensure-sidecar-stubs:
#!/usr/bin/env bash
set -euo pipefail
TARGET=$(rustc -vV | sed -n 's|host: ||p')
# Tauri externalBin on Windows requires the `.exe` suffix (#2492).
EXT=""
case "$TARGET" in *windows*) EXT=".exe";; esac
mkdir -p desktop/src-tauri/binaries
for bin in buzz-acp buzz-agent buzz-dev-mcp git-credential-nostr buzz; do
touch "desktop/src-tauri/binaries/${bin}-${TARGET}"
touch "desktop/src-tauri/binaries/${bin}-${TARGET}${EXT}"
done

# Ensure Docker dev services (Postgres, Redis, etc.) are running and healthy
Expand Down Expand Up @@ -233,12 +236,14 @@ desktop-release-build target="aarch64-apple-darwin":
#!/usr/bin/env bash
set -euo pipefail
TARGET={{target}}
EXT=""
case "$TARGET" in *windows*) EXT=".exe";; esac
mkdir -p desktop/src-tauri/binaries
touch "desktop/src-tauri/binaries/buzz-acp-$TARGET"
touch "desktop/src-tauri/binaries/buzz-agent-$TARGET"
touch "desktop/src-tauri/binaries/buzz-dev-mcp-$TARGET"
touch "desktop/src-tauri/binaries/git-credential-nostr-$TARGET"
touch "desktop/src-tauri/binaries/buzz-$TARGET"
touch "desktop/src-tauri/binaries/buzz-acp-$TARGET$EXT"
touch "desktop/src-tauri/binaries/buzz-agent-$TARGET$EXT"
touch "desktop/src-tauri/binaries/buzz-dev-mcp-$TARGET$EXT"
touch "desktop/src-tauri/binaries/git-credential-nostr-$TARGET$EXT"
touch "desktop/src-tauri/binaries/buzz-$TARGET$EXT"
pnpm install
cd {{desktop_dir}} && pnpm tauri build --features mesh-llm --target {{target}}

Expand Down Expand Up @@ -477,10 +482,12 @@ desktop-standalone *ARGS: _ensure-sidecar-stubs
export PATH="{{justfile_directory()}}/bin:$PATH"
cargo build -p buzz-acp -p buzz-agent -p buzz-dev-mcp -p buzz-cli -p git-credential-nostr
TARGET=$(rustc -vV | sed -n 's|host: ||p')
EXT=""
case "$TARGET" in *windows*) EXT=".exe";; esac
TARGET_DIR=$(cargo metadata --format-version 1 --no-deps | node -p "JSON.parse(require('fs').readFileSync(0, 'utf8')).target_directory")
for bin in buzz-acp buzz-agent buzz-dev-mcp git-credential-nostr buzz; do
cp "${TARGET_DIR}/debug/${bin}" "desktop/src-tauri/binaries/${bin}-${TARGET}"
chmod +x "desktop/src-tauri/binaries/${bin}-${TARGET}"
cp "${TARGET_DIR}/debug/${bin}${EXT}" "desktop/src-tauri/binaries/${bin}-${TARGET}${EXT}"
chmod +x "desktop/src-tauri/binaries/${bin}-${TARGET}${EXT}"
done
cd {{desktop_dir}}
[[ -d node_modules ]] || pnpm install
Expand Down Expand Up @@ -512,9 +519,11 @@ staging *ARGS: bootstrap _ensure-sidecar-stubs
fi
# Replace the 0-byte sidecar stub with the real CLI binary so tauri dev picks it up.
TARGET=$(rustc -vV | sed -n 's|host: ||p')
EXT=""
case "$TARGET" in *windows*) EXT=".exe";; esac
TARGET_DIR=$(cargo metadata --format-version 1 --no-deps | node -p "JSON.parse(require('fs').readFileSync(0, 'utf8')).target_directory")
cp "${TARGET_DIR}/release/buzz" "desktop/src-tauri/binaries/buzz-${TARGET}"
chmod +x "desktop/src-tauri/binaries/buzz-${TARGET}"
cp "${TARGET_DIR}/release/buzz${EXT}" "desktop/src-tauri/binaries/buzz-${TARGET}${EXT}"
chmod +x "desktop/src-tauri/binaries/buzz-${TARGET}${EXT}"
cd {{desktop_dir}}
export BUZZ_RELAY_URL="wss://sprout-oss.stage.blox.sqprod.co"
source ../scripts/instance-env.sh
Expand Down
3 changes: 2 additions & 1 deletion desktop/src/features/onboarding/ui/DefaultConfigStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,8 @@ export function DefaultConfigStep({

return (
<OnboardingSlideTransition
className="flex min-h-full w-full flex-col items-center"
// pb clears the docked footer when the step frame scrolls under it.
className="flex min-h-full w-full flex-col items-center pb-20"
data-testid="onboarding-page-config"
direction={direction}
transitionKey={`default-config-${direction}`}
Expand Down
7 changes: 6 additions & 1 deletion desktop/src/shared/styles/globals/components.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,13 @@
}

.buzz-onboarding-step-frame {
/* Fill the shell under the chrome + docked CTA, but keep tall steps
(e.g. machine onboarding model defaults) scrollable instead of clipped
when max-height binds. */
min-height: min(1000px, max(0px, calc(100dvh - 106px - 7rem)));
max-height: 1000px;
max-height: min(1000px, max(0px, calc(100dvh - 106px - 7rem)));
overflow-x: hidden;
overflow-y: auto;
}

.buzz-onboarding-step-frame > .buzz-onboarding-slide,
Expand Down