fix(desktop): allow cross-machine agent mentions - #2514
Conversation
Signed-off-by: ansonhkg <ansonox@gmail.com>
Signed-off-by: ansonhkg <ansonox@gmail.com>
b6f6407 to
8e85aa1
Compare
|
I validated this branch against a production same-owner/two-Mac failure on Buzz Desktop 0.5.3. Production evidence (also posted on #3277): the secondary Mac's local keyless definition was enough to materialize a different local identity, attach that duplicate pubkey as the outbound Local validation of this PR (
The E2E assertion on both the signed One regression extension would make the production trap explicit: seed the invoking client with no keyed or keyless local definition for the remote agent and assert the member candidate still appears. A keyless same-name definition must not be required as a discovery projection; in 0.5.3 it can be minted into a new local execution owner. For our exact deployment, membership-based admission is the only currently functional path because the centrally hosted native Hermes identity is a real |
Summary
@autocomplete when they are members of the current channelrespond-topolicy check and keep non-member remote agents hiddenptag without trying to start the remote process locallyRoot cause
The mention pipeline correctly identified shared relay agents as invocable, but then applied a local-managed-agent filter before the policy-aware eligibility check. That removed every agent not managed by the current desktop, including valid members running on another machine. Manually typing the name did not restore the missing pubkey tag, so the remote ACP process never received the mention.
User impact
Users connected to the same community can now discover and invoke an in-channel agent from another machine, subject to that agent's existing
respond-topolicy.Manual test
just desktop-standalone.@autocomplete and responded after selection.Validation
just cip-tag routing, and no local process startunwrap()orunsafecodejust testnot run; this is a desktop-only change and does not modify relay, database, or auth behaviorFixes #2508