fix(acp): surface agent authentication failures - #2577
Closed
purybr365 wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Pury <puryp365@gmail.com> Signed-off-by: Pury <puryp365@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcpErrorProblem
An ACP adapter can initialize successfully and later return a generic JSON-RPC error such as
-32000: Authentication requiredwhile processing a prompt. The harness previously treated that as transient, requeued it with exponential backoff, and produced no channel-visible explanation while the process remained alive.ACP does not currently define one universal authentication error code, so the shared ACP error layer recognizes Buzz's typed
-32001code plus common adapter-agnostic authentication messages. Queue orchestration only consumes that classification and reuses the existing signed, threaded failure-notice transport.Validation
CARGO_INCREMENTAL=0 just cicargo test -p buzz-acp(584 unit tests, 9 integration tests, doc tests)cargo clippy -p buzz-acp --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkChecklist