Skip to content

fix(acp): surface agent authentication failures - #2577

Closed
purybr365 wants to merge 1 commit into
block:mainfrom
purybr365:fix/visible-agent-auth-errors
Closed

fix(acp): surface agent authentication failures#2577
purybr365 wants to merge 1 commit into
block:mainfrom
purybr365:fix/visible-agent-auth-errors

Conversation

@purybr365

Copy link
Copy Markdown

Summary

  • classify adapter-reported authentication failures centrally in AcpError
  • surface terminal credential failures immediately through the existing threaded failure-notice path
  • avoid silently retrying the same credential failure while preserving retry behavior for unrelated adapter errors

Problem

An ACP adapter can initialize successfully and later return a generic JSON-RPC error such as -32000: Authentication required while processing a prompt. The harness previously treated that as transient, requeued it with exponential backoff, and produced no channel-visible explanation while the process remained alive.

ACP does not currently define one universal authentication error code, so the shared ACP error layer recognizes Buzz's typed -32001 code plus common adapter-agnostic authentication messages. Queue orchestration only consumes that classification and reuses the existing signed, threaded failure-notice transport.

Validation

  • CARGO_INCREMENTAL=0 just ci
  • cargo test -p buzz-acp (584 unit tests, 9 integration tests, doc tests)
  • cargo clippy -p buzz-acp --all-targets -- -D warnings
  • cargo fmt --all -- --check
  • git diff --check

Checklist

  • Changes are focused and use the existing ACP error and failure-notice architecture
  • Authentication and negative retry-policy cases are covered by tests
  • Full repository CI gate passes
  • No public API or endpoint documentation changes are required

Co-authored-by: Pury <puryp365@gmail.com>
Signed-off-by: Pury <puryp365@gmail.com>
@purybr365
purybr365 requested a review from a team as a code owner July 23, 2026 18:01
@purybr365

Copy link
Copy Markdown
Author

Closing as superseded by #2751, which was merged in commit 0a9c26e and implements the same authentication-error handling: classify auth failures, avoid futile retries, surface a user-facing re-authentication notice, and cover the behavior with regression tests. Thanks!

@purybr365 purybr365 closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant