fix(desktop): allow channel member agents in mentions - #2693
Conversation
Co-authored-by: Grafton <143531040+satsdisco@users.noreply.github.com> Signed-off-by: Grafton <143531040+satsdisco@users.noreply.github.com>
|
Heads-up from a parallel investigation on #5363, in case it's useful here. The We opened #5483 with a data-layer fix: merge Not a claim that this PR is wrong — the two layers are compatible — just that the eligibility change alone may not be reproducibly verifiable against relay-published agents. Full analysis in #5363. |
Summary
Fixes Desktop mention resolution for remote/shared managed agents that are already channel members but are not owned by the local Desktop.
The verified user-facing failure was: Satsdisco could see a remote managed agent, Fizz, as a channel member, but typing
@Fizzdid not produce the agentptag. Another user's@Fizzmessage did include Fizz'sptag, which narrowed the issue to local Desktop mention candidate filtering/resolution rather than relay delivery.Root Cause
Desktop mention autocomplete had two related assumptions that broke for remote managed agents:
That is too strict for shared channel usage. Channel membership is the concrete signal that the identity can be mentioned in that channel. Whether the remote agent actually responds is still enforced by the receiving agent/relay policy.
Changes
ptag.Validation
Validated at commit
cff618911b0c26d810055cb1b787f3cc487ffed5:corepack pnpm --dir desktop test- 3,374 passed, 0 failedcorepack pnpm --dir desktop typecheckcorepack pnpm --dir desktop buildAlso validated manually via the replacement DMG: typing
@Fizzfrom Satsdisco now works and emits the intended mention behavior.