Skip to content

fix(desktop): resolve the Hermes preset by a command that is on PATH #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SHL0MS wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −4
Open

fix(desktop): resolve the Hermes preset by a command that is on PATH #3334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e715ad7
fix(desktop): resolve the Hermes preset by a command that is on PATH
SHL0MS Jul 28, 2026
3b9a61b
Merge branch 'main' into PR #3334 to clear stale-base CI failure
Jul 28, 2026
4a0d08e
chore(desktop): ratchet discovery.rs file-size limit 1860 -> 1864
Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion desktop/scripts/check-file-sizes.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,10 @@ const overrides = new Map([
// +19: codex-acp minimum-version gate — MIN_CODEX_ACP_VERSION plus the strict
// three-component parse in probe_codex_acp_version, so an outdated 1.x adapter
// is offered a reinstall instead of classifying as Available on major alone.
["src-tauri/src/managed_agents/discovery.rs", 1860],
// +4 (1860 -> 1864): Hermes preset resolves via `hermes acp` with a comment
// explaining why the venv-only `hermes-acp` console script fails on a default
// install. Queued to split with the rest of this list.
["src-tauri/src/managed_agents/discovery.rs", 1864],
// BYOH — save_custom_harness_to_dir (backup-swap atomic write) + save_and_warm /
// delete_and_warm (persist-mutex serialization for concurrent-safe registry
// refresh, B-6). Also: id/collision/load/registry tests (from the file base) +
Expand Down
10 changes: 7 additions & 3 deletions desktop/src-tauri/src/managed_agents/discovery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1595,10 +1595,14 @@ const PRESET_HARNESSES: &[PresetHarness] = &[
PresetHarness {
id: "hermes",
label: "Hermes Agent",
command: "hermes-acp",
args: &[],
// `hermes` is the launcher the Hermes installer writes to ~/.local/bin,
// which is on the login-shell PATH. The `hermes-acp` console script
// exists only inside Hermes' own venv, which is not, so resolving by
// that name fails on a default install.
command: "hermes",
args: &["acp"],
install_instructions_url: "https://hermes-agent.nousresearch.com",
install_hint: "Buzz talks to Hermes Agent through its hermes-acp command.",
install_hint: "Buzz talks to Hermes Agent through its ACP mode (hermes acp).",
underlying_cli: None,
},
PresetHarness {
Expand Down
Loading