fix(desktop): render projects header and create menu at zero projects - #3508
Open
puneetv05 wants to merge 1 commit into
Open
fix(desktop): render projects header and create menu at zero projects#3508puneetv05 wants to merge 1 commit into
puneetv05 wants to merge 1 commit into
Conversation
puneetv05
marked this pull request as ready for review
July 29, 2026 10:33
Author
|
Hi @thomaspblock , could you please review #3508 when you get a chance? It fixes #3504, where the create menu disappears when there are zero projects, preventing users from adding their first project in Buzz. All checks are passing. Thanks! |
ProjectsView returned <EmptyState /> before the page header and toolbar were built, and the create menu lives in that toolbar. A relay with no repo announcements therefore had no way to create its first project from the UI — the button that creates a project only appeared once a project already existed. Drop the early return and render the empty state in the content slot instead, the way EmptyFilteredState already does, so the header, filter toolbar, and + menu stay mounted at every project count. Adds an e2e spec that hides every seeded mock project to reach a zero-project relay, then drives the create menu through to the create project dialog. Both cases fail without the fix. Fixes block#3504 Signed-off-by: Puneet Verma <puneet@saanvis.com>
puneetv05
force-pushed
the
fix/projects-empty-state-create-menu
branch
from
August 8, 2026 06:59
f45eeb4 to
862e776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3504.
Problem
ProjectsViewreturned<EmptyState />before constructing the page header, toolbar, and<ProjectsCreateMenu />. On a relay with zero projects, the UI therefore hid the only control capable of creating the first project.Fix
<EmptyState />in the normal content slot whenprojects.length === 0.+create menu mounted for every project count.Scope
This is intentionally a three-file regression fix. It does not change empty-state copy, add another CTA, or modify project deletion/tombstone behavior. Broader related implementations are tracked in #4118 and #5205.
Unhiding the create menu also exposes its Issue and Pull Request items when there are no projects. Their existing dialogs already handle an empty project list by disabling submission until a project is available.
Current-main adaptation
The branch is rebased onto current
main. The E2E setup now:FEATURE_OVERRIDES_STORAGE_KEYrather than a versioned string literal;30621project announcement as well as the kind30617repository announcements;playwright.config.ts.Verification
pnpm typecheckpnpm build:e2epnpm exec playwright test --project=smoke tests/e2e/projects-empty-state.spec.ts— 2 passedThe two focused tests verify: