fix(desktop): try navigator.clipboard before arboard for npub/nsec copy - #3513
Open
JoeJoeflyn wants to merge 1 commit into
Open
fix(desktop): try navigator.clipboard before arboard for npub/nsec copy#3513JoeJoeflyn wants to merge 1 commit into
JoeJoeflyn wants to merge 1 commit into
Conversation
- Add copyTextWithFallback helper in shared/lib/clipboard that tries navigator.clipboard.writeText first, falling back to the Tauri/arboard path. - Use it in MembershipDenied and NsecMaskedDisplay copy buttons. - Implement the text-selection fallback in MembershipDenied that the catch block only commented about before. arboard without wayland-data-control writes to the XWayland clipboard, which Wayland-native apps never see. set_text returns Ok so the checkmark fires with an empty clipboard. - `pnpm run typecheck` - `just desktop-standalone` → copy npub and nsec → paste in a Wayland-native app → text present Closes block#2896 Signed-off-by: JoeJoeflyn <thaitainguyen336@gmail.com>
JoeJoeflyn
force-pushed
the
fix/member-npub-copy
branch
from
July 29, 2026 10:43
49d4e2e to
205d6f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
arboard without wayland-data-control writes to the XWayland clipboard, which Wayland-native apps never see. set_text returns Ok so the checkmark fires with an empty clipboard.
Verification
pnpm run typecheckjust desktop-standalone→ copy npub and nsec → paste in a Wayland-native app → text presentCloses #2896