fix(desktop): keep Create controls on empty Projects - #3620
Closed
austin-thesing wants to merge 1 commit into
Closed
fix(desktop): keep Create controls on empty Projects#3620austin-thesing wants to merge 1 commit into
austin-thesing wants to merge 1 commit into
Conversation
The empty-state early return skipped the Create menu and dialog, so first-time and empty-fetch users could not create a repository from the UI. Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Austin Thesing <austin@designxdevelop.com> Signed-off-by: Austin Thesing <austin@designxdevelop.com>
This was referenced Aug 1, 2026
iroiro147
added a commit
to iroiro147/buzz
that referenced
this pull request
Aug 8, 2026
The Projects view returned its empty state before the PageHeader, toolbar, and ProjectsCreateMenu mounted, leaving no way to create the first project from an empty workspace. - Drop the projects.length === 0 early return; the main section now renders the empty state inside the page chrome so the Create menu stays mounted. - EmptyState gains an optional onCreateRepository CTA that opens the create-project dialog directly. - Covers both entry points (toolbar Create menu, empty-state button) with a Playwright smoke spec. Reimplements the approach from the closed PR block#3620, tracked in block#4009. Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Originating channel:
18fca54c-dc63-4dbd-a1c3-2afba0e44c0d(dxd-link).Test plan
pnpm exec biome checkon touched filespnpm exec tsc --noEmitpnpm exec playwright test --project=smoke tests/e2e/projects-empty-create.spec.ts+Create menu and empty-state Create repository open the create dialogMade with Cursor