Fix workflow deletion consistency and visibility - #3650
Draft
physikal wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Josh <boody@physikal.com> Signed-off-by: Josh <boody@physikal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
30620definition event togetherWhy
Workflow scheduling is driven by the database row, while Desktop and CLI discovery are driven by the kind
30620event. The previous delete path removed only the row and trusted the pubkey embedded in the incoming coordinate. That allowed deletion events to be accepted even when their post-commit side effect could not remove the actual workflow, and left stale definitions visible.Validation
cargo test -p buzz-relay— 784 executed, 0 failurescargo clippy -p buzz-relay --all-targets -- -D warnings— passedjust ci— all Rust, Desktop, web, analysis, and build gates passed; the run stopped on an unrelated existing mobile widget test:ChannelDetailPage keeps follow mode off while a tall newest message stays visiblecrates/buzz-relay/src/handlers/side_effects.rsBuzz channel:
eb4d3406-52ba-47f7-84ce-0aed2f2c084b