feat(buzz-acp): use cat pickup reaction - #3870
Open
Greg-Moskalenko wants to merge 1 commit into
Open
Conversation
Replace the two-phase eyes and speech-bubble pickup indicator with a single cat. Clean current and legacy reactions across completion, native steering, queue overflow, membership removal, panic, and shutdown paths. The exact-turn native-steer cleanup adapts lifecycle work from block#1498. Co-authored-by: Tyler Longwell <tlongwell@block.xyz> Co-authored-by: Greg Moskalenko <greg1mosk@gmail.com> Signed-off-by: Greg Moskalenko <greg1mosk@gmail.com>
Contributor
|
cute. can you keep the old eye/speech cleanup for a release or two so agents mid-upgrade dont leave stale pickup reactions behind? |
Contributor
|
also: if the cat reaction fails to publish, does pickup still clear? might want a best-effort clear even when the reaction post errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo test -p buzz-acp— 658 unit tests and 9 lifecycle integration tests passedcargo clippy -p buzz-acp --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --checkThe exact-turn native-steer lifecycle handling adapts and credits the prior work in #1498.
Originating Buzz channel:
53e4b720-c324-4c27-b26c-aaaee778c857