-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(ci): restore GLIBC 2.35 compatibility for deb packages #3955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,10 +18,19 @@ permissions: | |
|
|
||
| jobs: | ||
| build: | ||
| name: Build Linux canary | ||
| name: Build Linux canary (${{ matrix.target }}) | ||
| if: github.repository == 'block/buzz' | ||
| runs-on: ubuntu-latest | ||
| container: ubuntu:24.04@sha256:4fbb8e6a8395de5a7550b33509421a2bafbc0aab6c06ba2cef9ebffbc7092d90 | ||
| strategy: | ||
| matrix: | ||
| include: | ||
| - target: AppImage | ||
| container: ubuntu:24.04@sha256:4fbb8e6a8395de5a7550b33509421a2bafbc0aab6c06ba2cef9ebffbc7092d90 | ||
| bundles: appimage | ||
| - target: Debian | ||
| container: ubuntu:22.04 | ||
| bundles: deb | ||
| container: ${{ matrix.container }} | ||
| timeout-minutes: 60 | ||
| permissions: | ||
| contents: read | ||
|
|
@@ -170,11 +179,12 @@ jobs: | |
| ./scripts/bundle-sidecars.sh | ||
|
|
||
| - name: Build Linux Tauri app | ||
| run: cd desktop && pnpm tauri build --ci --bundles deb,appimage --config src-tauri/tauri.canary.conf.json | ||
| run: cd desktop && pnpm tauri build --ci --bundles ${{ matrix.bundles }} --config src-tauri/tauri.canary.conf.json | ||
| env: | ||
| CMAKE_POLICY_VERSION_MINIMUM: "3.5" | ||
|
|
||
| - name: Fix AppImage (remove infra libs, symlink system GStreamer) | ||
| if: matrix.target == 'AppImage' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 Nit: the |
||
| # fix-appimage.sh checks for TAURI_SIGNING_PRIVATE_KEY and skips | ||
| # re-signing when absent, so no signing env vars are needed here. | ||
| # Repacking still runs, removing the Mesa/GLib/GStreamer conflict libs. | ||
|
|
@@ -202,26 +212,26 @@ jobs: | |
| set -euo pipefail | ||
| BUNDLE_DIR="desktop/src-tauri/target/release/bundle" | ||
|
|
||
| DEB=$(find "$BUNDLE_DIR/deb" -name '*.deb' -type f | head -1) | ||
| if [[ -z "$DEB" ]]; then | ||
| echo "::error::No DEB found in $BUNDLE_DIR/deb" | ||
| exit 1 | ||
| fi | ||
| echo "deb=$DEB" >> "$GITHUB_OUTPUT" | ||
|
|
||
| APPIMAGE=$(find "$BUNDLE_DIR/appimage" -name '*.AppImage' -type f | head -1) | ||
| if [[ -z "$APPIMAGE" ]]; then | ||
| echo "::error::No AppImage found in $BUNDLE_DIR/appimage" | ||
| exit 1 | ||
| if [ "${{ matrix.target }}" = "Debian" ]; then | ||
| DEB=$(find "$BUNDLE_DIR/deb" -name '*.deb' -type f | head -1) | ||
| if [[ -z "$DEB" ]]; then | ||
| echo "::error::No DEB found in $BUNDLE_DIR/deb" | ||
| exit 1 | ||
| fi | ||
| echo "path=$DEB" >> "$GITHUB_OUTPUT" | ||
| else | ||
| APPIMAGE=$(find "$BUNDLE_DIR/appimage" -name '*.AppImage' -type f | head -1) | ||
| if [[ -z "$APPIMAGE" ]]; then | ||
| echo "::error::No AppImage found in $BUNDLE_DIR/appimage" | ||
| exit 1 | ||
| fi | ||
| echo "path=$APPIMAGE" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| echo "appimage=$APPIMAGE" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Upload Linux canary packages | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 | ||
| with: | ||
| name: buzz-linux-canary-${{ github.sha }} | ||
| path: | | ||
| ${{ steps.artifacts.outputs.deb }} | ||
| ${{ steps.artifacts.outputs.appimage }} | ||
| name: buzz-linux-canary-${{ matrix.target }}-${{ github.sha }} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 Heads-up, not blocking: the artifact name changes from |
||
| path: ${{ steps.artifacts.outputs.path }} | ||
| if-no-files-found: error | ||
| retention-days: 7 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -424,7 +424,7 @@ | |
| ${{ steps.artifacts.outputs.sig }} | ||
|
|
||
| release-linux: | ||
| name: Release Linux | ||
| name: Release Linux (AppImage) | ||
| if: github.repository == 'block/buzz' | ||
| runs-on: ubuntu-latest | ||
| # Digest-pinned like the SHA-pinned actions below; Renovate keeps it fresh. | ||
|
|
@@ -573,7 +573,7 @@ | |
| BUZZ_UPDATER_ENDPOINT: https://github.com/block/buzz/releases/download/buzz-desktop-latest/latest.json | ||
|
|
||
| - name: Build Linux Tauri app | ||
| run: cd desktop && pnpm tauri build --verbose --ci --bundles deb,appimage --config src-tauri/tauri.release.conf.json | ||
| run: cd desktop && pnpm tauri build --verbose --ci --bundles appimage --config src-tauri/tauri.release.conf.json | ||
| env: | ||
| BUZZ_UPDATER_PUBLIC_KEY: ${{ secrets.BUZZ_UPDATER_PUBLIC_KEY || secrets.SPROUT_UPDATER_PUBLIC_KEY }} | ||
| BUZZ_UPDATER_ENDPOINT: https://github.com/block/buzz/releases/download/buzz-desktop-latest/latest.json | ||
|
|
@@ -602,13 +602,6 @@ | |
| run: | | ||
| BUNDLE_DIR="desktop/src-tauri/target/release/bundle" | ||
|
|
||
| DEB=$(find "$BUNDLE_DIR/deb" -name '*.deb' -type f | head -1) | ||
| if [[ -z "$DEB" ]]; then | ||
| echo "::error::No DEB found in $BUNDLE_DIR/deb" | ||
| exit 1 | ||
| fi | ||
| echo "deb=$DEB" >> "$GITHUB_OUTPUT" | ||
|
|
||
| APPIMAGE=$(find "$BUNDLE_DIR/appimage" -name '*.AppImage' -type f | head -1) | ||
| if [[ -z "$APPIMAGE" ]]; then | ||
| echo "::error::No AppImage found in $BUNDLE_DIR/appimage" | ||
|
|
@@ -647,11 +640,116 @@ | |
| name: desktop-release-linux-x64 | ||
| if-no-files-found: error | ||
| path: | | ||
| ${{ steps.linux-artifacts.outputs.deb }} | ||
| ${{ steps.linux-artifacts.outputs.appimage }} | ||
| ${{ steps.linux-artifacts.outputs.archive }} | ||
| ${{ steps.linux-artifacts.outputs.sig }} | ||
|
|
||
| release-linux-deb: | ||
| name: Release Linux (Debian) | ||
| if: github.repository == 'block/buzz' | ||
| runs-on: ubuntu-latest | ||
| container: ubuntu:22.04 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 |
||
| needs: setup | ||
| timeout-minutes: 60 | ||
| permissions: | ||
| contents: read | ||
| defaults: | ||
| run: | ||
| shell: bash | ||
| steps: | ||
| - name: Install system dependencies | ||
| env: | ||
| DEBIAN_FRONTEND: noninteractive | ||
| run: | | ||
| apt-get update \ | ||
| -o Acquire::Retries=3 \ | ||
| -o Acquire::http::Timeout=30 \ | ||
| -o Acquire::https::Timeout=30 | ||
| apt-get install -y --no-install-recommends \ | ||
| -o Acquire::Retries=3 \ | ||
Check warningCode scanning / zizmor detects commit SHAs that don't match their version comment tags Warning
detects commit SHAs that don't match their version comment tags
|
||
|
|
||
| -o Acquire::http::Timeout=30 \ | ||
| -o Acquire::https::Timeout=30 \ | ||
| -o DPkg::Lock::Timeout=120 \ | ||
| build-essential \ | ||
| ca-certificates \ | ||
| curl \ | ||
| desktop-file-utils \ | ||
| file \ | ||
| git \ | ||
| libasound2-dev \ | ||
| libayatana-appindicator3-dev \ | ||
| libgtk-3-dev \ | ||
| librsvg2-dev \ | ||
| libssl-dev \ | ||
| libwebkit2gtk-4.1-dev \ | ||
| libxdo-dev \ | ||
| patchelf \ | ||
| pkg-config \ | ||
| squashfs-tools \ | ||
| wget \ | ||
| xdg-utils | ||
|
|
||
| - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6 | ||
| with: | ||
| ref: ${{ needs.setup.outputs.source_sha }} | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - name: Mark workspace safe for git (containerized job) | ||
| run: git config --global --add safe.directory "$GITHUB_WORKSPACE" | ||
|
|
||
| - name: Verify tag-bound release source | ||
| env: | ||
| VERSION: ${{ needs.setup.outputs.version }} | ||
| run: scripts/verify-release-ref.sh desktop-v "$VERSION" | ||
|
|
||
| - uses: cashapp/activate-hermit@cea9af7913204a965fd488637a8d1811bba2e616 # v1 | ||
|
|
||
| - uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2 | ||
| with: | ||
| workspaces: desktop/src-tauri | ||
| lookup-only: true | ||
|
|
||
| - name: Install desktop dependencies | ||
| run: just desktop-install-ci | ||
|
|
||
| - name: Patch version | ||
| env: | ||
| VERSION: ${{ needs.setup.outputs.version }} | ||
| run: | | ||
| cd desktop && node scripts/set-version-from-tag.mjs "$VERSION" | ||
| cd src-tauri && cargo update --workspace | ||
|
|
||
| - name: Build sidecars | ||
| run: | | ||
| cargo build --release -p buzz-acp -p buzz-agent -p buzz-dev-mcp -p git-credential-nostr -p buzz-cli | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 Blocking: stale base — main's sidecar build now includes |
||
| ./scripts/bundle-sidecars.sh | ||
|
|
||
| - name: Build Linux Tauri app | ||
| run: cd desktop && pnpm tauri build --verbose --ci --bundles deb --config src-tauri/tauri.release.conf.json | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 Blocking: Also, main's |
||
| env: | ||
| CMAKE_POLICY_VERSION_MINIMUM: "3.5" | ||
|
|
||
| - name: Locate Linux build artifacts | ||
| id: linux-artifacts | ||
| run: | | ||
| BUNDLE_DIR="desktop/src-tauri/target/release/bundle" | ||
|
|
||
| DEB=$(find "$BUNDLE_DIR/deb" -name '*.deb' -type f | head -1) | ||
| if [[ -z "$DEB" ]]; then | ||
| echo "::error::No DEB found in $BUNDLE_DIR/deb" | ||
| exit 1 | ||
| fi | ||
| echo "deb=$DEB" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Stage Linux release artifacts | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 | ||
| with: | ||
| name: desktop-release-linux-deb | ||
| if-no-files-found: error | ||
| path: | | ||
| ${{ steps.linux-artifacts.outputs.deb }} | ||
|
|
||
| release-windows: | ||
| name: Release Windows | ||
| runs-on: windows-latest | ||
|
|
@@ -784,10 +882,11 @@ | |
| needs.release.result == 'success' && | ||
| needs.release-macos-x64.result == 'success' && | ||
| needs.release-linux.result == 'success' && | ||
| needs.release-linux-deb.result == 'success' && | ||
| needs.release-windows.result == 'success' && | ||
| github.ref == format('refs/tags/desktop-v{0}', needs.setup.outputs.version) | ||
| runs-on: ubuntu-latest | ||
| needs: [setup, release, release-macos-x64, release-linux, release-windows] | ||
| needs: [setup, release, release-macos-x64, release-linux, release-linux-deb, release-windows] | ||
| timeout-minutes: 10 | ||
| permissions: | ||
| contents: write | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 Same digest-pin ask as in
release.yml— pinubuntu:22.04to the current jammy digest so Renovate tracks it.