fix(desktop): remove 880px reading cap in focus-mode thread - #4007
Draft
treywood wants to merge 1 commit into
Draft
fix(desktop): remove 880px reading cap in focus-mode thread#4007treywood wants to merge 1 commit into
treywood wants to merge 1 commit into
Conversation
Focus mode capped its thread content at an 880px centered column with mx-auto margins and a px-10 inner gutter, producing large empty side gutters on wide drawers. Every sibling reading surface — split thread view, the channel timeline, and the inbox — renders the same message content full-width; the cap was unique to focus mode. Drop the cap by passing columnMaxWidthPx: undefined in the focus branch of getThreadPanelLayout, matching split mode. This flows through both the message list and composer columns and the loading skeleton via the shared hasConstrainedColumn gate, so nothing shifts when replies load. Removes the now-unused THREAD_FOCUS_COLUMN_MAX_WIDTH_PX constant and its import. Co-authored-by: Trey Wood <treyw@squareup.com> Signed-off-by: Trey Wood <treyw@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the 880px reading-column cap in focus-mode thread view so thread content fills the drawer edge-to-edge, matching every sibling reading surface.
Previously, focus mode capped its thread content at an 880px centered column (
mx-auto) with apx-10inner gutter, producing large empty side gutters on wide drawers. The split thread view, the channel timeline, and the inbox all render the same message content full-width — the cap was unique to focus mode.How
threadPanelLayout.ts— the focus branch ofgetThreadPanelLayoutnow passescolumnMaxWidthPx: undefinedinstead ofTHREAD_FOCUS_COLUMN_MAX_WIDTH_PX, which is exactly what split mode already does. This drops the max-width, themx-autocentering, and thepx-10gutter. The gate flows through the message list, the composer, and the loading skeleton via the sharedhasConstrainedColumncheck, so nothing shifts when replies load in.threadFocusLayout.ts— removes the now-unusedTHREAD_FOCUS_COLUMN_MAX_WIDTH_PXconstant and its import.Net: 2 files, +4/−13.
Verification
tsc --noEmit— cleanbiome checkon touched files — cleanContext
Discussed in the buzz-focus-thread-width channel — the 880px cap was a deliberate reading-measure choice from #2108 but a lightly-held one (single author, never iterated, inconsistent with sibling views). Removing it for consistency and to eliminate the distracting gutters.
Opening as draft — a human will move it to Ready for Review.