Skip to content

feat(acp): allow host policy to decide permission requests #4066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Silentpartnercoding wants to merge 1 commit into
base: main
Choose a base branch
from
+338 −46
Open

feat(acp): allow host policy to decide permission requests #4066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions crates/buzz-acp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,20 @@ The harness works with any agent that implements the [ACP spec](https://agentcli
- Accept `session/prompt` with a text message and stream `session/update` notifications
- Return a `stopReason` (`end_turn`, `cancelled`, `max_tokens`, etc.)

### Permission-policy boundary

`AcpClient` exposes an injectable asynchronous policy for
`session/request_permission`. No policy means deny: Buzz selects an offered
reject option when that is unambiguous, or returns `cancelled`. Callback errors,
timeouts, invalid selections, and cancellation also fail closed. The historical
`allow_once` behavior is available only through the explicit
`AcpClient::allow_once_permission_policy()` compatibility policy.

This is cooperative control of the ACP session/request_permission exchange only.
It does not enforce or attest filesystem, subprocess, network, MCP, runtime, or
operating-system containment. An agent or tool that does not ask is outside this
policy boundary.

Set `BUZZ_ACP_AGENT_COMMAND` and `BUZZ_ACP_AGENT_ARGS` to point at your agent binary.

## Testing
Expand Down
Loading