fix(relay): log ambiguous workflow @mentions instead of dropping silently (#4436) - #4506
Open
Chessing234 wants to merge 2 commits into
Open
fix(relay): log ambiguous workflow @mentions instead of dropping silently (#4436)#4506Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
Dropping the p tag is intentional, but silence made healthy sends look like dead agents (block#4436). Return matched ambiguous names and log them. Signed-off-by: Taksh <takshkothari09@gmail.com>
Ensure a second @fizz in the same workflow text does not duplicate the ambiguous-name signal. Signed-off-by: Taksh <takshkothari09@gmail.com>
Contributor
Author
|
note: #3991 extracts this resolver into buzz-core for desktop typed mentions — if that lands first i'll rebase the warn onto the shared helper. |
Contributor
Author
|
@kalvinnchau small relay fix: log ambiguous workflow @mentions instead of dropping them silently. would love a review + merge if you have cycles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Nameresolution still refuses to pick among duplicate display nameswarn!'d with the channel id (Ambiguous @Name mentions are dropped silently: send succeeds, mention_pubkeys is empty, nothing logged or surfaced #4436)Test plan
cargo test -p buzz-relay --lib workflow_sink::testssend_messagewith@Fizzwhen two members share that name; relay logs the warn and still posts the message without a Fizzptag