docs(e2e): use pnpm build:e2e in perf specs and screenshot skill (#3207) - #4508
Open
Chessing234 wants to merge 2 commits into
Open
docs(e2e): use pnpm build:e2e in perf specs and screenshot skill (#3207)#4508Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
A plain production build strips the mock Tauri bridge, so every smoke/perf spec that calls installMockBridge fails at boot (block#3207). Signed-off-by: Taksh <takshkothari09@gmail.com>
Keep the desktop-screenshot skill gotcha aligned with AGENTS.md so a stale plain build does not silently drop the mock bridge (block#3207). Signed-off-by: Taksh <takshkothari09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm build:e2einstead ofpnpm buildpnpm run build, which strips the mock bridge and breaks all smoke specs #3207: plain production builds strip the mock bridge and break smoke/perf specsTest plan
pnpm build:e2ecd desktop && pnpm build:e2e && pnpm exec playwright test --project=smokestill boots the mock bridge