ci: run buzz-workflow and buzz-acp lib tests in the unit gate - #4590
Open
mfanafuthimhlanga wants to merge 1 commit into
Open
ci: run buzz-workflow and buzz-acp lib tests in the unit gate#4590mfanafuthimhlanga wants to merge 1 commit into
mfanafuthimhlanga wants to merge 1 commit into
Conversation
`just test-unit` covers buzz-core, buzz-auth, buzz-voice, buzz-cli, buzz-db --lib, buzz-conformance, buzz-push-gateway, and buzz-backend-kubernetes. buzz-workflow and buzz-acp are referenced by no `cargo test` or `nextest` invocation anywhere in .github/workflows/ or scripts/run-tests.sh — buzz-acp appears only in build and release contexts (Justfile binary loops, sprig.yml). This is the condition the buzz-backend-kubernetes block immediately above already names: "nothing in CI runs `cargo test --workspace` — workspace membership alone buys clippy/check, not a single executed test." Both crates were enumerated nowhere, so `cargo clippy --workspace --all-targets` compiled their tests while nothing executed them: buzz-workflow --lib 154 tests buzz-acp --lib 661 tests Both are infra-free and pass clean: Summary [0.306s] 154 tests run: 154 passed, 2 skipped Summary [13.080s] 661 tests run: 661 passed, 0 skipped buzz-relay is deliberately not addressed here — it needs Postgres, and api::admin and api::media carry four infra-dependent tests that are not #[ignore]d, so `-p buzz-relay --lib` hangs ~30s per test and then fails. That belongs with block#3461. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mfanafuthi Mhlanga <309677444+mfanafuthimhlanga@users.noreply.github.com>
mfanafuthimhlanga
force-pushed
the
ci/unit-gate-workflow-acp
branch
from
August 3, 2026 19:39
09ebfd2 to
9704552
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just test-unitcoversbuzz-core,buzz-auth,buzz-voice,buzz-cli,buzz-db --lib,buzz-conformance,buzz-push-gateway, andbuzz-backend-kubernetes.buzz-workflowandbuzz-acpare referenced by nocargo testornextestinvocation anywhere in.github/workflows/orscripts/run-tests.sh.buzz-acpappears only in build and release contexts — the Justfile binary loops andsprig.yml.This is exactly the condition the
buzz-backend-kubernetesblock immediately above already names:Both crates were enumerated nowhere, so
cargo clippy --workspace --all-targetscompiled their test targets while nothing executed them.buzz-workflowbuzz-acpThis is the same class of gap as #3461 (
buzz-relay: 771 of 804 never execute). This PR does not addressbuzz-relay— see below.Why it matters
buzz-acpowns the agent concurrency model: per-channel queues with per-channel in-flight tracking (queue.rs), the fungible worker pool (pool.rs), and mention-filtered per-agent subscriptions (relay.rs).buzz-workflowowns the workflow schema and executor, including therequest_approvaldefinition-time validation that WF-08 work (#2377, #3327) touches.Both are areas with active open bugs, which is consistent with neither having had a test gate.
Verification
Both suites are infra-free and pass clean. Run on a fork, since fork PRs need maintainer approval before workflows execute:
buzz-acpruns with 0 skipped — no#[ignore]d subset, no infra-gated early returns.I could not run
just cilocally (no working Rust toolchain on this machine), so localfmt/clippywere not run. The change is seven lines of Justfile and CI's own Rust Lint job covers it.Why
buzz-relayis excludedDeliberately out of scope, and it is why #3461 is not trivially fixable.
-p buzz-relay --libsurfaces four tests that need Postgres but are not#[ignore]d:Each hangs ~30s on a DB connection and then fails, and nextest's fail-fast then cancelled 628 of 840 remaining tests. Marking those four
#[ignore]looks like the right first step for #3461, but it is a separate change against a different crate and I did not want to bundle it here.Note on method
I confirmed these tests were not merely passing-by-default before trusting the result: I added a test, watched CI go green, then inverted the assertion so it had to fail — CI stayed green, which is what surfaced the gap. Under nextest's default profile a test that never runs is indistinguishable from one that passes, so the green run alone proved nothing.
Context: I found this while evaluating the workflow and approval-gate layer, which is where my interest in the codebase is.