test(acp): harden permission mode regression coverage - #4626
Open
maxitoon wants to merge 1 commit into
Open
Conversation
Signed-off-by: Maxime Tolos <max@maximetolos.com>
maxitoon
force-pushed
the
acp-permission-mode-regression-tests
branch
from
August 6, 2026 23:38
b5f6635 to
8dbecdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session/set_config_optionwithconfigId: "mode"and the requested wire value.session/set_config_optionrequest.This remains test-only and complementary to #4280, which owns the production-side support for stable
configOptionsmode advertisements. These tests pin the existingmodes.availableModesgate and the existing bounded permission-mode request path; they do not add stable-advertisement behavior or change permission policy.Related context
mainpermission API usesAcceptEdits; the tests were adapted from the published head's removedBypassPermissionsvalue after fix(acp): reject unattended permission requests #4609 merged.session/new, not at the permission-mode setter. This PR does not claim to fix thesession/newhang.read -tACP harness path.Verification
cargo fmt --all -- --checkcargo test -p buzz-acp --lib permission_mode -- --nocapture— 11 passedcargo test -p buzz-acp --lib— 692 passedcargo test -p buzz-acp --all-targets— 692 library tests, 9 integration tests, and 0 binary tests passedgit diff --checkThe temporary capture files use unique UUID-based paths and an RAII cleanup guard; subprocesses are explicitly shut down before assertions. No production files are changed.