Skip to content

test(acp): harden permission mode regression coverage - #4626

Open
maxitoon wants to merge 1 commit into
block:mainfrom
maxitoon:acp-permission-mode-regression-tests
Open

test(acp): harden permission mode regression coverage#4626
maxitoon wants to merge 1 commit into
block:mainfrom
maxitoon:acp-permission-mode-regression-tests

Conversation

@maxitoon

@maxitoon maxitoon commented Aug 3, 2026

Copy link
Copy Markdown

Summary

  • Add a regression test proving the permission-mode request is bounded when an agent accepts stdin but never responds.
  • Add positive end-to-end coverage proving an advertised non-default mode emits session/set_config_option with configId: "mode" and the requested wire value.
  • Add a negative end-to-end gate proving an unadvertised mode emits no session/set_config_option request.

This remains test-only and complementary to #4280, which owns the production-side support for stable configOptions mode advertisements. These tests pin the existing modes.availableModes gate and the existing bounded permission-mode request path; they do not add stable-advertisement behavior or change permission policy.

Related context

Verification

  • cargo fmt --all -- --check
  • cargo test -p buzz-acp --lib permission_mode -- --nocapture — 11 passed
  • cargo test -p buzz-acp --lib — 692 passed
  • cargo test -p buzz-acp --all-targets — 692 library tests, 9 integration tests, and 0 binary tests passed
  • git diff --check

The temporary capture files use unique UUID-based paths and an RAII cleanup guard; subprocesses are explicitly shut down before assertions. No production files are changed.

@maxitoon
maxitoon requested a review from a team as a code owner August 3, 2026 22:15
Signed-off-by: Maxime Tolos <max@maximetolos.com>
@maxitoon
maxitoon force-pushed the acp-permission-mode-regression-tests branch from b5f6635 to 8dbecdc Compare August 6, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant