docs(arch): correct rate-limiter, limits, and pipeline drift in ARCHITECTURE.md - #4680
Open
kushaim wants to merge 1 commit into
Open
docs(arch): correct rate-limiter, limits, and pipeline drift in ARCHITECTURE.md#4680kushaim wants to merge 1 commit into
kushaim wants to merge 1 commit into
Conversation
…TECTURE.md Fixes block#4210. The Known Limitations table claimed rate limiting was not implemented and the rate-limiter trait only had a test stub. The Redis-backed RedisRateLimiter in crates/buzz-pubsub/src/rate_limiter.rs is wired into the relay and enforced on WS connect, per-message, and the HTTP bridge (crates/buzz-relay/src/api/bridge.rs:30); an operator reading the prior gap row would have assumed the relay was unprotected. Also corrects the client-facing limits (frame size 65,536 -> 524,288, historical filter cap 500 -> 1,000) in four places, drops the stale SEARCH INDEX pipeline step (the search_tsv tsvector is generated on insert; the legacy Typesense worker and its search_index_tx mpsc are gone), removes the deleted search_index_tx field from the AppState struct, removes the wrong 'implement the rate limiter' bullet from buzz-pubsub's Does NOT list, and updates the search_tsv exclusion description to cover the positive-allowlist shape fresh installs adopt via migration 0008. Not touched: ALL_KINDS count, the buzz-acp LOC table, and the e2e test counts. The issue itself flags these as 'least load-bearing - consider dropping exact numbers'; out of scope for a surgical fix. Signed-off-by: kushaim <carlossilvajimenez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4210.
The Known Limitations table claimed rate limiting was not implemented and the rate-limiter trait only had a test stub. The Redis-backed
RedisRateLimiterincrates/buzz-pubsub/src/rate_limiter.rsis wired into the relay and enforced on WS connect, per-message, and the HTTP bridge (crates/buzz-relay/src/api/bridge.rs:30) — an operator reading the prior gap row would have assumed the relay was unprotected.Also corrects:
search_tsvtsvector is generated on insert; the legacy Typesense worker and itssearch_index_txmpsc are gone (handlers/event.rs:502-506).AppStatestruct no longer shows the deletedsearch_index_txfield.search_tsvexclusion description covers the positive-allowlist shape fresh installs adopt via migration 0008.Not touched:
ALL_KINDScount, the buzz-acp LOC table, and the e2e test counts. The issue itself flags these as "least load-bearing — consider dropping exact numbers"; out of scope for a surgical fix.