-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(desktop): share managed agents across owners #4857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thegarty
wants to merge
2
commits into
block:main
Choose a base branch
from
thegarty:codex/cross-owner-agent-sharing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
desktop/src-tauri/src/managed_agents/types/relay_agent_info.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| use super::RespondTo; | ||
|
|
||
| /// A relay-published agent directory entry (kind:10100), as handed to the | ||
| /// frontend by `list_relay_agents`. | ||
| /// | ||
| /// This type crosses two boundaries with opposite casing conventions, and | ||
| /// getting either wrong fails silently — the frontend just sees `undefined`, | ||
| /// and every relay-published agent quietly stops being mentionable. | ||
| /// | ||
| /// * **Serializes camelCase.** The TypeScript `RelayAgent` type reads | ||
| /// `agentType` / `channelIds` / `respondTo` / `respondToAllowlist`. Emitting | ||
| /// snake_case here left all four `undefined`, so `relayAgentIsSharedWithUser` | ||
| /// could never return true for any relay agent. | ||
| /// * **Deserializes either casing.** kind:10100 event content is snake_case | ||
| /// (see `agents_from_events`), so every renamed field keeps a snake_case | ||
| /// `alias`. Dropping those would break directory parsing. | ||
| /// | ||
| /// Both directions are pinned by tests in `types/tests.rs`. | ||
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct RelayAgentInfo { | ||
| pub pubkey: String, | ||
| pub name: String, | ||
| #[serde(alias = "agent_type")] | ||
| pub agent_type: String, | ||
| pub channels: Vec<String>, | ||
| #[serde(default, alias = "channel_ids")] | ||
| pub channel_ids: Vec<String>, | ||
| pub capabilities: Vec<String>, | ||
| pub status: String, | ||
| #[serde(default, alias = "respond_to")] | ||
| pub respond_to: Option<RespondTo>, | ||
| #[serde(default, alias = "respond_to_allowlist")] | ||
| pub respond_to_allowlist: Vec<String>, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flips
list_relay_agentsIPC output to camelCase, butfromRawRelayAgentindesktop/src/shared/api/tauri.tsstill reads the old snake_case properties (agent_type,channel_ids,respond_to,respond_to_allowlist). In the real app, those fields now map toundefined/[]/null, sorelayAgentIsSharedWithUsercannot admit any relay-published agent and the cross-owner mention fix remains broken; update or remove the raw mapper as part of this casing change.AGENTS.md reference: AGENTS.md:L434-L434
Useful? React with 👍 / 👎.