feat(desktop): add zcode-acp preset to the harness catalog - #4889
Open
jpalmae wants to merge 1 commit into
Open
Conversation
Following up on block#3131 (closed as superseded by the harness catalog shipped in v0.5.0 / block#2773), this adds `zcode-acp` as a tier-2 preset so ZCode is one-click discoverable in the Desktop runtime gallery. `zcode-acp` is a standalone ACP adapter (mirroring amp-acp / hermes-acp) that drives the ZCode CLI through its stdio app-server. It speaks ACP v1 directly, so no other Buzz-side change is needed: https://github.com/jpalmae/zcode-acp - New PresetHarness entry: command=zcode-acp, args=[], underlying_cli=zcode (so Buzz reports AdapterMissing when the ZCode CLI is present but the adapter is not — same shape as the amp preset). - Mapped logo in PRESET_LOGOS and an original CC0 placeholder SVG so the presetLogos coverage guard passes. Happy to swap in an official Z.ai mark under redistribution terms if/when available. - CREDITS.md row recording the placeholder provenance. Signed-off-by: jpalmae <39507014+jpalmae@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #3131 (closed as superseded by the harness catalog shipped in v0.5.0 / #2773), this adds
zcode-acpas a tier-2 preset so ZCode is one-click discoverable in the Desktop runtime gallery — the data-entry PR @wpfleger96 suggested in #3131 (comment).What
zcode-acpis a standalone ACP adapter (mirroringamp-acp/hermes-acp) that drives the ZCode CLI through its stdioapp-server. It speaks ACP v1 directly, so no other Buzz-side change is needed beyond this preset entry.tool.updated→ToolCall/ToolCallUpdate),session/requestPermissionbridged bidirectionally,authenticate/logout(Z.AI OAuth init/poll + credential store compatible withzcode login),UsageUpdate.Changes (small data-entry, as suggested)
desktop/src-tauri/src/managed_agents/discovery/presets.rsPresetHarnessentry inPRESET_HARNESSES, shaped exactly likeamp:command: \"zcode-acp\",args: &[],underlying_cli: Some(\"zcode\")(so Desktop reportsAdapterMissingwhen the ZCode CLI is present but the adapter is not).desktop/src/features/onboarding/ui/RuntimeIcon.tsx\"zcode-acp\"→/harness-logos/zcode-acp.svginPRESET_LOGOS(satisfiespresetLogos.test.mjs).desktop/public/harness-logos/zcode-acp.svgdesktop/public/harness-logos/CREDITS.mdWhy
underlying_cli: Some(\"zcode\")zcode-acpis an adapter that spawnsnode zcode.cjs ...— i.e. it wraps a separately-installed vendor bundle. Mirroringamp(which setsunderlying_cli: Some(\"amp\")), this makes Desktop distinguish “ZCode installed but the adapter missing” from “neither installed”, surfacing the right install guidance.Verification
presetLogos.test.mjsassertions replicated locally (same regex the test uses): everyPRESET_HARNESSESid has either an inlineRUNTIME_MARKSentry or aPRESET_LOGOSentry whose file exists on disk, and there are no orphanPRESET_LOGOSkeys. ✓amppreset (same fields, same order, trailing comma), so it compiles under the crate'srustfmt/clippy gates. The fullcargo check -p buzz-desktoprequires a prebuiltbuzz-acpbinary inbuild.rsthat isn't available outside the release pipeline, so I could not run it end-to-end locally — but the change is additive data-only and mirrors a sibling.Out of scope
codex), happy to adjust.buzz-acpalready works without this PR (per feat(buzz-acp): register zcode-acp as a known ACP agent #3131 feedback); this PR is purely about Desktop discoverability.