test(buzz-agent): wait for steer response in steer_rejected_on_empty_prompt - #5005
Open
santhiprakash wants to merge 1 commit into
Open
test(buzz-agent): wait for steer response in steer_rejected_on_empty_prompt#5005santhiprakash wants to merge 1 commit into
santhiprakash wants to merge 1 commit into
Conversation
…prompt Signed-off-by: Santhi Prakash <b.santhiprakash@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
steer_rejected_on_empty_promptwas flaky because its receive loop stopped as soon as thesession/promptresponse arrived, even if thesession/steerrejection had not yet been read. This made the test fail whenever the prompt response was delivered before the steer rejection.Wait specifically for the steer response (matching the pattern already used by
steer_rejected_when_no_active_runandsteer_rejected_on_run_id_mismatch) so the assertion no longer depends on response ordering.Related issue
Fixes #4939
Testing
cargo test -p buzz-agent --test fake_llm -- steer_rejected_on_empty_promptpassed 10/10 times after the change.