fix(desktop): keep trailing space after persistent agent mentions - #5021
Open
VaibhavJain2609 wants to merge 1 commit into
Open
fix(desktop): keep trailing space after persistent agent mentions#5021VaibhavJain2609 wants to merge 1 commit into
VaibhavJain2609 wants to merge 1 commit into
Conversation
TipTap markdown setContent strips trailing whitespace, so post-send "Keep addressed agents active" restores left the caret glued to the mention chip and the next keystroke collapsed it. Re-attach the space via insertText after markdown parse. Signed-off-by: Vaibhav Jain <vaibhavjain@Vaibhavs-MacBook-Pro.local> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setContentstrips trailing whitespace, so post-send "Keep addressed agents active" restores left the caret glued to the mention chip and the next keystroke collapsed it (@Pearl→@Pearlh).insertTexttransaction after markdown parse (setEditorMarkdownPreservingTrailingWhitespace), wired into composersetContent/setContentAndFocusEnd.emitUpdate: false/preventUpdate), plus an e2e regression that types after a post-send restore.Test plan
node --import ./test-loader.mjs --experimental-strip-types --test src/features/messages/lib/setEditorMarkdownPreservingTrailingWhitespace.test.mjs(7 passing)pnpm exec tsc --noEmitindesktop/persistent-agent-audience.spec.ts(includes new post-send trailing-space case)Made with Cursor