Skip to content

fix(desktop): let imported and recovered identities finish onboarding #5228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesbillman merged 1 commit into from
Aug 7, 2026
+31 −0
Merged

fix(desktop): let imported and recovered identities finish onboarding #5228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions desktop/src/features/onboarding/machineOnboarding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@ export function useMachineOnboardingState({
completionKey(MACHINE_ONBOARDING_COMPLETION_STORAGE_KEY, pubkey),
"true",
);
// Clear the "continuing" marker so completion actually settles the flow.
// Imported/recovered identities set continuingPubkeyRef to pin the stage
// to "onboarding" until setup finishes; leaving it set after complete()
// keeps the stage pinned forever, so Skip/Next appear to do nothing.
continuingPubkeyRef.current = null;
setCompletedPubkey(pubkey);
},
[currentPubkey],
Expand Down
26 changes: 26 additions & 0 deletions desktop/tests/e2e/onboarding.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,32 @@ test("first-launch key import continues to machine setup", async ({ page }) => {
await expect(page.getByTestId("app-loading-gate")).toHaveCount(0);
});

test("imported-key users can skip out of harness setup", async ({ page }) => {
// Regression: importing an existing key sets the onboarding state machine's
// "continuing" marker, which pinned the stage to onboarding even after
// complete() ran — so Skip/Next silently did nothing. The fresh-key skip
// tests never exercised the import path, so this gap shipped. Prove an
// imported-key user actually leaves onboarding on Skip.
await installMockBridge(page, undefined, {
skipCommunitySeed: true,
skipOnboardingSeed: true,
});
await page.goto("/");

await page.getByRole("button", { name: "Use an existing key" }).click();
const importedNsec = nsecEncode(hexToBytes(TEST_IDENTITIES.alice.privateKey));
await page.getByTestId("nostr-import-nsec-input").fill(importedNsec);
await page.getByTestId("nostr-import-submit").click();

await expect(page.getByTestId("onboarding-page-2")).toBeVisible();
await page.getByTestId("onboarding-setup-skip").click();

// Reaching community onboarding proves machine onboarding completed rather
// than staying pinned on the setup step.
await expect(page.getByText("Join or create a community")).toBeVisible();
await expect(page.getByTestId("onboarding-page-2")).toHaveCount(0);
});

test("first-launch encrypted backup import asks for a passphrase and continues", async ({
page,
}) => {
Expand Down
Loading