fix(acp): preserve permission requests by default - #5325
Open
wolfyy970 wants to merge 1 commit into
Open
Conversation
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Author
|
@wesbillman I rechecked this exact head against the 0.5.8 main. It is mergeable and the only ACP overlap is the revert this builds on. This keeps agents working without making blanket It is blocked only on human review now. Could you take a look when you have a window? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5323 and Desktop 0.5.8 restored working agents by restoring
bypassPermissionsas the implicit default. This follow-up removes that implicit blanket bypass while keeping it available when an operator chooses it.The default now leaves each adapter in its normal per-request flow. For current Claude and Codex adapters, the harness selects the offered
allow_once, so agents can work and publish without a stranded human prompt. Each grant remains visible to the harness, and Goose receives no unsupported mode override.This is the safer default after the immediate recovery for #5290, #5303, #5317 and #5332. #5106 remains the full owner-facing Ask, Allow and Reject policy.
The regression drives a real fake adapter through the prompt wire, captures the exact permission response and proves the turn completes. The focused permission suite, ambient-environment regression, formatting, strict Clippy and adversarial review pass.