Add returnable: false widget fields to the test schema - #1123
Merged
Conversation
jwils
force-pushed
the
joshauw/returnable-widgets-acceptance
branch
from
April 11, 2026 12:54
81e87d8 to
c006569
Compare
jwils
force-pushed
the
joshauw/fetchable-false-prototype
branch
from
April 14, 2026 01:28
caabea3 to
fd1d61a
Compare
jwils
force-pushed
the
joshauw/returnable-widgets-acceptance
branch
from
April 14, 2026 02:07
c006569 to
97915e5
Compare
jwils
changed the title
returnable: false widgets and preserve highlighting
jwils
force-pushed
the
joshauw/returnable-widgets-acceptance
branch
from
April 14, 2026 02:51
97915e5 to
4784514
Compare
jwils
changed the title
returnable: false widget fields to the test schema
Add `internal_name` and `internal_details` to the Widget test schema, along with the new WidgetInternalDetails object type. Update the shared widget factories so generated widget events satisfy the new schema, and regenerate the datastore config artifacts so hidden widget fields are excluded from _source. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jwils
force-pushed
the
joshauw/returnable-widgets-acceptance
branch
from
April 14, 2026 17:12
4784514 to
e96bfd0
Compare
jwils
marked this pull request as ready for review
April 14, 2026 18:50
jwils
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwondrusch and
myronmarston
as code owners
April 14, 2026 18:50
myronmarston
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal_nameandinternal_detailsasreturnable: falsefields on the widgets test schemaWidgetInternalDetailsobject type and update shared widget factories so generated widget events satisfy the new schema_source.excludesentries for the hidden widget fieldsTesting
bundle exec rake schema_artifacts:check VERBOSE=truebundle exec rspec elasticgraph-indexer/spec/unit/elastic_graph/indexer/spec_support/event_matcher_spec.rb elasticgraph-indexer/spec/unit/elastic_graph/indexer/operation/factory_spec.rbbundle exec rspec elasticgraph-indexer/spec/integration/elastic_graph/indexer/processor_spec.rbbundle exec rspec elasticgraph-indexer/spec/acceptance/multi_source_indexing_spec.rb