index_data.painless script cleanup - #1308
Merged
ellisandrews-toast merged 1 commit intoJul 15, 2026
Merged
Conversation
ellisandrews-toast
requested review from
BrianSigafoos-SQ,
bsorbo,
jwils,
jwondrusch,
marcdaniels-toast,
myronmarston and
rossroberts-toast
as code owners
July 14, 2026 19:54
myronmarston
approved these changes
Jul 14, 2026
ellisandrews-toast
deleted the
OLAP-739-painless-script-cleanups-nested-sourced-from
branch
July 15, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the unresolved (non-blocking) review comments left on
index_data.painlessin #1252.Mechanical cleanups only — no behavior change; verified by the existing nested + top-level multi-source acceptance specs.
segment.fieldmap-access shorthand inbuildNestedElementKeyPartsandextractNestedElementextractNestedElementfindInListcomment (first-match-wins) and reword the unbounded-growth note to reference Prune orphaned __nested_sourced_data entries to avoid unbounded growth #1270Schema artifacts regenerated (
INDEX_DATA_UPDATE_SCRIPT_IDupdated accordingly).