Address PR comments

src/lib/es2015.collection.d.ts

@@ -58,14 +58,14 @@ interface WeakMap<K extends WeakKey, V> {
     has(key: K): boolean;
     /**
      * Adds a new element with a specified key and value.
-     * @param key Must be an object.
+     * @param key Must be an object or symbol.
      */
     set(key: K, value: V): this;
 }
 
 interface WeakMapConstructor {
-    new <K extends object = object, V = any>(entries?: readonly [K, V][] | null): WeakMap<K, V>;
-    readonly prototype: WeakMap<object, any>;
+    new <K extends WeakKey = WeakKey, V = any>(entries?: readonly [K, V][] | null): WeakMap<K, V>;
+    readonly prototype: WeakMap<WeakKey, any>;
 }
 declare var WeakMap: WeakMapConstructor;
 
@@ -109,7 +109,7 @@ interface ReadonlySet<T> {
 
 interface WeakSet<T extends WeakKey> {
     /**
-     * Appends a new object to the end of the WeakSet.
+     * Appends a new value to the end of the WeakSet.
      */
     add(value: T): this;
     /**
@@ -118,7 +118,7 @@ interface WeakSet<T extends WeakKey> {
      */
     delete(value: T): boolean;
     /**
-     * @returns a boolean indicating whether an object exists in the WeakSet or not.
+     * @returns a boolean indicating whether a value exists in the WeakSet or not.
      */
     has(value: T): boolean;
 }

tests/baselines/reference/acceptSymbolAsWeakType.errors.txt

@@ -1,8 +1,7 @@
-tests/cases/compiler/acceptSymbolAsWeakType.ts(18,3): error TS2339: Property 'registerSymbol' does not exist on type 'FinalizationRegistry<symbol>'.
-tests/cases/compiler/acceptSymbolAsWeakType.ts(19,3): error TS2339: Property 'unregisterSymbol' does not exist on type 'FinalizationRegistry<symbol>'.
+tests/cases/compiler/acceptSymbolAsWeakType.ts(18,15): error TS2345: Argument of type 'null' is not assignable to parameter of type 'symbol'.
 
 
-==== tests/cases/compiler/acceptSymbolAsWeakType.ts (2 errors) ====
+==== tests/cases/compiler/acceptSymbolAsWeakType.ts (1 errors) ====
     const s: symbol = Symbol('s');
 
     const ws = new WeakSet([s]);
@@ -20,9 +19,7 @@ tests/cases/compiler/acceptSymbolAsWeakType.ts(19,3): error TS2339: Property 'un
     wr.deref();
 
     const f = new FinalizationRegistry<symbol>(() => {});
-    f.registerSymbol(s, null);
-      ~~~~~~~~~~~~~~
-!!! error TS2339: Property 'registerSymbol' does not exist on type 'FinalizationRegistry<symbol>'.
-    f.unregisterSymbol(s);
-      ~~~~~~~~~~~~~~~~
-!!! error TS2339: Property 'unregisterSymbol' does not exist on type 'FinalizationRegistry<symbol>'.
+    f.register(s, null);
+                  ~~~~
+!!! error TS2345: Argument of type 'null' is not assignable to parameter of type 'symbol'.
+    f.unregister(s);

tests/baselines/reference/acceptSymbolAsWeakType.js

@@ -16,10 +16,11 @@ const wr = new WeakRef(s);
 wr.deref();
 
 const f = new FinalizationRegistry<symbol>(() => {});
-f.registerSymbol(s, null);
-f.unregisterSymbol(s);
+f.register(s, null);
+f.unregister(s);
 
 //// [acceptSymbolAsWeakType.js]
+"use strict";
 const s = Symbol('s');
 const ws = new WeakSet([s]);
 ws.add(s);
@@ -33,5 +34,5 @@ wm.delete(s);
 const wr = new WeakRef(s);
 wr.deref();
 const f = new FinalizationRegistry(() => { });
-f.registerSymbol(s, null);
-f.unregisterSymbol(s);
+f.register(s, null);
+f.unregister(s);

tests/baselines/reference/acceptSymbolAsWeakType.symbols

@@ -69,11 +69,15 @@ const f = new FinalizationRegistry<symbol>(() => {});
 >f : Symbol(f, Decl(acceptSymbolAsWeakType.ts, 16, 5))
 >FinalizationRegistry : Symbol(FinalizationRegistry, Decl(lib.es2021.weakref.d.ts, --, --), Decl(lib.es2021.weakref.d.ts, --, --))
 
-f.registerSymbol(s, null);
+f.register(s, null);
+>f.register : Symbol(FinalizationRegistry.register, Decl(lib.es2021.weakref.d.ts, --, --))
 >f : Symbol(f, Decl(acceptSymbolAsWeakType.ts, 16, 5))
+>register : Symbol(FinalizationRegistry.register, Decl(lib.es2021.weakref.d.ts, --, --))
 >s : Symbol(s, Decl(acceptSymbolAsWeakType.ts, 0, 5))
 
-f.unregisterSymbol(s);
+f.unregister(s);
+>f.unregister : Symbol(FinalizationRegistry.unregister, Decl(lib.es2021.weakref.d.ts, --, --))
 >f : Symbol(f, Decl(acceptSymbolAsWeakType.ts, 16, 5))
+>unregister : Symbol(FinalizationRegistry.unregister, Decl(lib.es2021.weakref.d.ts, --, --))
 >s : Symbol(s, Decl(acceptSymbolAsWeakType.ts, 0, 5))
 

tests/baselines/reference/acceptSymbolAsWeakType.types

@@ -58,10 +58,10 @@ wm.has(s);
 >s : symbol
 
 wm.get(s);
->wm.get(s) : boolean
->wm.get : (key: symbol) => boolean
+>wm.get(s) : boolean | undefined
+>wm.get : (key: symbol) => boolean | undefined
 >wm : WeakMap<symbol, boolean>
->get : (key: symbol) => boolean
+>get : (key: symbol) => boolean | undefined
 >s : symbol
 
 wm.delete(s);
@@ -78,29 +78,29 @@ const wr = new WeakRef(s);
 >s : symbol
 
 wr.deref();
->wr.deref() : symbol
->wr.deref : () => symbol
+>wr.deref() : symbol | undefined
+>wr.deref : () => symbol | undefined
 >wr : WeakRef<symbol>
->deref : () => symbol
+>deref : () => symbol | undefined
 
 const f = new FinalizationRegistry<symbol>(() => {});
 >f : FinalizationRegistry<symbol>
 >new FinalizationRegistry<symbol>(() => {}) : FinalizationRegistry<symbol>
 >FinalizationRegistry : FinalizationRegistryConstructor
 >() => {} : () => void
 
-f.registerSymbol(s, null);
->f.registerSymbol(s, null) : any
->f.registerSymbol : any
+f.register(s, null);
+>f.register(s, null) : void
+>f.register : (target: WeakKey, heldValue: symbol, unregisterToken?: WeakKey | undefined) => void
 >f : FinalizationRegistry<symbol>
->registerSymbol : any
+>register : (target: WeakKey, heldValue: symbol, unregisterToken?: WeakKey | undefined) => void
 >s : symbol
 >null : null
 
-f.unregisterSymbol(s);
->f.unregisterSymbol(s) : any
->f.unregisterSymbol : any
+f.unregister(s);
+>f.unregister(s) : void
+>f.unregister : (unregisterToken: WeakKey) => void
 >f : FinalizationRegistry<symbol>
->unregisterSymbol : any
+>unregister : (unregisterToken: WeakKey) => void
 >s : symbol
 

tests/cases/compiler/acceptSymbolAsWeakType.ts

@@ -1,3 +1,4 @@
+// @strict: true
 // @lib: esnext
 // @target: esnext
 
@@ -18,5 +19,5 @@ const wr = new WeakRef(s);
 wr.deref();
 
 const f = new FinalizationRegistry<symbol>(() => {});
-f.registerSymbol(s, null);
-f.unregisterSymbol(s);
+f.register(s, null);
+f.unregister(s);