Resource optimisations 2#5718
Conversation
|
The above does not change anything when compiled as the font never gets used. I'm dumb. |
d79a1c2 to
f09ec04
Compare
|
@bluepilledgreat Could you please add this to the main branch so I can include it in this PR? That'd be great. |
See #5621 (comment). |
I linked that comment myself.. (I was referring to the local branch in question.) |
|
Weird, it looked like it was linked to a different part of the conversation. Good to know. |
I'll look into this for the next update after 2.11.0. Going through all the PRs now. |
f09ec04 to
36202ad
Compare
WebP works just fine as a static image without transparency since Windows 10 1809. Your second statement is also false, it's like saying HEIF is exclusive to iPhones. Please do more thorough research before making a comment. |
|
Like i said, WPF does not natively support WebP. |
|
Also android phones also has HEIFs. |
WPF relies on WIC to handle images, which supports WebP since Windows 10 1809. The codec required is pre installed on both Windows 10 and 11. We shouldn't account for custom Windows isos if that's what you're getting at. Have you tried building the PR locally to check if it's broken?
That's exactly my point? |
This PR saves an entire ~2MB!!!!! (we take what we can get)
As with the previous PR about this, the icon fonts inside of WPF.UI are about 25% of Bloxstrap's file size. They cannot be changed to a woff2 without it breaking. (it would've saved ~2MB too, what a shame).
Related PR: bloxstraplabs/wpfui#9
I've saved the branch before the force-push just incase.